Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Export logical_not #96315

Closed
wants to merge 3 commits into from
Closed

[ONNX] Export logical_not #96315

wants to merge 3 commits into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Mar 8, 2023 •
edited

Stack from ghstack (oldest at bottom):

Fixes #95154

@BowenBao
[ONNX] Export logical_not
f1fb18f 
[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Mar 8, 2023
BowenBao added a commit that referenced this pull request Mar 8, 2023
@BowenBao
[ONNX] Export logical_not
aeb87ea 
ghstack-source-id: a6c8ea24ec49506395ebe35a5bffa1ac7514e4e2
Pull Request resolved: #96315
@BowenBao BowenBao linked an issue Mar 8, 2023 that may be closed by this pull request
RuntimeError: Exporting the operator logical_not to ONNX opset version 9 is not supported. #95154
Closed
@BowenBao BowenBao marked this pull request as ready for review March 8, 2023 18:24
@BowenBao BowenBao requested a review from abock as a code owner March 8, 2023 18:24
@BowenBao BowenBao added module: onnx Related to torch.onnx topic: improvements topic category labels Mar 8, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 8, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96315

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 82e7e9d:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

BowenBao added a commit that referenced this pull request Mar 8, 2023
@BowenBao
[ONNX] Export logical_not
443e966 
ghstack-source-id: 3434436ec2854702de1abb49552a5f24e8f2db85
Pull Request resolved: #96315
justinchuby
justinchuby reviewed Mar 9, 2023
View reviewed changes
test/onnx/test_pytorch_onnx_onnxruntime.py
@@ -4905,6 +4905,24 @@ def forward(self, x, y):
y = torch.randint(10, (2, 3, 5), dtype=torch.long)
self.run_test(XorModel(), input_args=(x, y))

@skipIfUnsupportedMinOpsetVersion(9)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable a opinfo test? I am finishing up #92087 which also fixes the test file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, very robust this time.

BowenBao added a commit that referenced this pull request Mar 9, 2023
@BowenBao
[ONNX] Export logical_not
c77bd2b 
ghstack-source-id: 945b4cc90dc8be0ffa34f5587401d65c44538ab7
Pull Request resolved: #96315
@BowenBao
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 10, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / ios-12-5-1-x86-64 / build (default, 1, 1, macos-12)

Details for Dev Infra team Raised by workflow job

@BowenBao
Copy link
Collaborator Author

@pytorchbot merge -f "unrelated failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@BowenBao @cyyever
[ONNX] Export logical_not (#96315)
5ed9831 
Fixes pytorch/pytorch#95154

Pull Request resolved: pytorch/pytorch#96315
Approved by: https://github.com/justinchuby
@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/211/head branch June 8, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

@abock abock Awaiting requested review from abock

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RuntimeError: Exporting the operator logical_not to ONNX opset version 9 is not supported.
4 participants
@BowenBao @pytorchmergebot @justinchuby @pytorchbot