Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Do not run 'deduplicate_initializers' when 'keep_initializers_as_inputs' is True #96320

Closed
wants to merge 3 commits into from
Closed

[ONNX] Do not run 'deduplicate_initializers' when 'keep_initializers_as_inputs' is True #96320

wants to merge 3 commits into from

Commits on Mar 8, 2023

  1. [ONNX] Do not run 'deduplicate_initializers' when 'keep_initializers_… 

    …as_inputs' is True

[ghstack-poisoned]
    @BowenBao
    BowenBao committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    0e9b0f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Update on "[ONNX] Do not run 'deduplicate_initializers' when 'keep_in… 

    …itializers_as_inputs' is True"


### Proposal
When arg of 'keep_initializers_as_inputs' is True, it's quite possible that parameters are set by initializer of input.
Hence we should disable de-duplicate initializer optimization when 'keep_initializers_as_inputs==True'.

- [ ] Update doc related to `keep_initializers_as_inputs`.

[ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    e4bb10d View commit details
    Browse the repository at this point in the history

  2. Update on "[ONNX] Do not run 'deduplicate_initializers' when 'keep_in… 

    …itializers_as_inputs' is True"


### Proposal
When arg of 'keep_initializers_as_inputs' is True, it's quite possible that parameters are set by initializer of input.
Hence we should disable de-duplicate initializer optimization when 'keep_initializers_as_inputs==True'.

- [ ] Update doc related to `keep_initializers_as_inputs`.

[ghstack-poisoned]
    @BowenBao
    BowenBao committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    6f59ab3 View commit details
    Browse the repository at this point in the history