Generate type match guard for torch.Size input #96421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suppose hypothetically, if the user code ends up working polymorphically over the SizeVariable, in such a way that a tuple would work, this type match is not necessary. But we do not carefully test for this. Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Mar 9, 2023
I suppose hypothetically, if the user code ends up working polymorphically over the SizeVariable, in such a way that a tuple would work, this type match is not necessary. But we do not carefully test for this. Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 625fafae308bb794dee147cf2bca246e68b86ae7 Pull Request resolved: #96421
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
Chillee,
jbschlosser,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96421
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 3c5fa0e: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
I suppose hypothetically, if the user code ends up working polymorphically over the SizeVariable, in such a way that a tuple would work, this type match is not necessary. But we do not carefully test for this. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Mar 9, 2023
I suppose hypothetically, if the user code ends up working polymorphically over the SizeVariable, in such a way that a tuple would work, this type match is not necessary. But we do not carefully test for this. Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 887c96920f948942a1bb8d4f21eec81f87759a2a Pull Request resolved: #96421
I suppose hypothetically, if the user code ends up working polymorphically over the SizeVariable, in such a way that a tuple would work, this type match is not necessary. But we do not carefully test for this. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
I suppose hypothetically, if the user code ends up working polymorphically over the SizeVariable, in such a way that a tuple would work, this type match is not necessary. But we do not carefully test for this. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Mar 10, 2023
I suppose hypothetically, if the user code ends up working polymorphically over the SizeVariable, in such a way that a tuple would work, this type match is not necessary. But we do not carefully test for this. Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 09218eda684a9321839032db0984ab9e50166513 Pull Request resolved: #96421
jansel
approved these changes
Mar 12, 2023
|
@pytorchbot merge |
Merge failedReason: This PR needs a label If not, please add the For more information, see Details for Dev Infra teamRaised by workflow job |
voznesenskym
approved these changes
Mar 12, 2023
|
@pytorchbot merge -f "unrelated jinja problem" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
I suppose hypothetically, if the user code ends up working polymorphically over the SizeVariable, in such a way that a tuple would work, this type match is not necessary. But we do not carefully test for this. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch/pytorch#96421 Approved by: https://github.com/jansel, https://github.com/voznesenskym
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
I suppose hypothetically, if the user code ends up working polymorphically over the SizeVariable, in such a way that a tuple would work, this type match is not necessary. But we do not carefully test for this. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch/pytorch#96421 Approved by: https://github.com/jansel, https://github.com/voznesenskym
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I suppose hypothetically, if the user code ends up working
polymorphically over the SizeVariable, in such a way that a tuple would
work, this type match is not necessary. But we do not carefully test
for this.
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire