Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support randn_like() for NT #96528

Closed
wants to merge 2 commits into from
Closed

Support randn_like() for NT #96528

wants to merge 2 commits into from

Conversation

jbschlosser
Copy link
Contributor

@jbschlosser jbschlosser commented Mar 10, 2023 •
edited

@jbschlosser
Support randn_like() for NT
bf54268 
[ghstack-poisoned]
@jbschlosser jbschlosser mentioned this pull request Mar 10, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 10, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96528

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2b4d3c2:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jbschlosser jbschlosser mentioned this pull request Mar 10, 2023
Closed
@jbschlosser jbschlosser added release notes: nested tensor Changes that have a direct impact on nested tensors topic: improvements topic category labels Mar 10, 2023
jbschlosser
jbschlosser commented Mar 10, 2023
View reviewed changes
test/test_nestedtensor.py
@@ -499,13 +499,15 @@ def test_zero_(self):
t.fill_(0.)
self.assertEqual(nt_ub, t)

@parametrize("func", [torch.ones_like, torch.zeros_like],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This currently passes, but I can imagine an alternative implementation of randn_like() for NT that doesn't have the property of "generating all random numbers at once -> gives same numbers as iteratively generating numbers matching underlying component sizes", and it could be argued this is no less correct. So I'm open to better forms of testing.

@jbschlosser
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 10, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda11_7-test / test

Details for Dev Infra team Raised by workflow job

@jbschlosser
Copy link
Contributor Author

@pytorchbot merge -f "spurious failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 190bf26c3bab197ac287ccb4442bfed85c686ae7 returned non-zero exit code 1

Auto-merging aten/src/ATen/native/native_functions.yaml
Auto-merging docs/source/nested.rst
CONFLICT (content): Merge conflict in docs/source/nested.rst
Auto-merging test/test_nestedtensor.py
CONFLICT (content): Merge conflict in test/test_nestedtensor.py
error: could not apply 190bf26c3ba... Support randn_like() for NT
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

@jbschlosser
Update on "Support randn_like() for NT"
2b4d3c2 
To satisfy an internal ask.

[ghstack-poisoned]
@jbschlosser
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

zhaojuanmao added a commit that referenced this pull request Mar 13, 2023
@zhaojuanmao
Support randn_like() for NT (#96528)
6bff380 
To satisfy an internal ask.
Pull Request resolved: #96528
Approved by: https://github.com/mikaylagawarecki, https://github.com/cpuhrsch
ghstack-source-id: d6e453446e8923ae94187a587601681c70450e7e
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023
@jbschlosser @cyyever
Support randn_like() for NT (#96528)
aef61d8 
To satisfy an internal ask.
Pull Request resolved: pytorch/pytorch#96528
Approved by: https://github.com/mikaylagawarecki, https://github.com/cpuhrsch
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
@jbschlosser @cyyever
Support randn_like() for NT (#96528)
635ee16 
To satisfy an internal ask.
Pull Request resolved: pytorch/pytorch#96528
Approved by: https://github.com/mikaylagawarecki, https://github.com/cpuhrsch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

@drisspg drisspg Awaiting requested review from drisspg

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nested tensor Changes that have a direct impact on nested tensors topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbschlosser @pytorchmergebot @cpuhrsch @mikaylagawarecki