Enable cadd_sparse for BFloat16 on CPU #96767
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96767
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f824aad: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
|
@nikitaved, Could you please review my changes? |
test/test_sparse.py
Outdated
| y = y.float().cuda() | ||
| x = x.float() | ||
| y = y.float() | ||
| if device == 'cuda': |
There was a problem hiding this comment.
This shouldn't be necessary since device is passed to _gen_sparse above.
In general it's strange that we annotate this with @dtypes(torch.double, torch.cdouble) and then convert to float right away.
There was a problem hiding this comment.
Thanks, I'll remove this part and change dtypes to torch.float
itaraban
force-pushed
the
enable_cadd_sparse_bfloat16
branch
from
9f93a0b
to
22ba0c9
Compare
bdhirsh
added
the
triaged
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase and merge by leaving the following comment on this PR: Details for Dev Infra teamRaised by workflow job |
itaraban
force-pushed
the
enable_cadd_sparse_bfloat16
branch
from
22ba0c9
to
f824aad
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Enabling **cadd_sparse** operation for BFloat16 on CPU to support BFloat16 operations in GNN libraries. Pull Request resolved: #96767 Approved by: https://github.com/jgong5, https://github.com/cpuhrsch
Enabling cadd_sparse operation for BFloat16 on CPU to support BFloat16 operations in GNN libraries.