Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uniform returning end point for BFloat16 and Half #96962

Closed
wants to merge 5 commits into from
Closed

Fix uniform returning end point for BFloat16 and Half #96962

wants to merge 5 commits into from

Commits on Mar 16, 2023

  1. Fix uniform returning end point for BFloat16 and Half 

    Fixes pytorch#96947

If we generate 1.0 - float_eps, the BFloat16 and Half constructors will
round this to 1.0 which is outside of the half-open range. This
changes the rounding of the last bit in the BFloat16 representation to
never round up. The result is we never go outside the end point and
also the from point now equally likely where before it was half as
likely.
    @peterbell10
    peterbell10 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    5cb5051 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Fix the range of random uniform 

    Fixes pytorch#96947
    @yuantailing @peterbell10
    yuantailing authored and peterbell10 committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    421f11b View commit details
    Browse the repository at this point in the history

  2. Remove dead code

    @peterbell10
    peterbell10 committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    6832038 View commit details
    Browse the repository at this point in the history

  3. Trigger CI

    @peterbell10
    peterbell10 committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    000d92b View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Bump flash_attention tolerance

    @peterbell10
    peterbell10 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    0bf366a View commit details
    Browse the repository at this point in the history