Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quantized] Fix return values of _get_name() in quantized ConvTranspose #97678

Closed
wants to merge 1 commit into from
Closed

[quantized] Fix return values of _get_name() in quantized ConvTranspose #97678

wants to merge 1 commit into from

Conversation

kiszk
Copy link
Contributor

@kiszk kiszk commented Mar 27, 2023 •
edited by pytorch-bot bot

This PR fixes incorrect return values of _get_name() in quantized ConvTranspose?d.

cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 27, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97678

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 Failures

As of commit 5b6d076:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@drisspg drisspg added oncall: quantization Quantization support in PyTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Mar 28, 2023
vkuzo
vkuzo approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@vkuzo vkuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kit1980
Copy link
Member

kit1980 commented Apr 6, 2023

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 6, 2023
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased quantized_conv_get_name onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout quantized_conv_get_name && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 1, 3, macos-m1-12), trunk / macos-12-py3-arm64 / test (default, 2, 3, macos-m1-12), trunk / macos-12-py3-arm64-mps / test (default, 1, 1)

Details for Dev Infra team Raised by workflow job

@kit1980
Copy link
Member

kit1980 commented Apr 7, 2023

@pytorchbot merge -ic

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: trunk / macos-12-py3-arm64 / test (default, 1, 3, macos-m1-12), trunk / macos-12-py3-arm64 / test (default, 2, 3, macos-m1-12), trunk / macos-12-py3-arm64-mps / test (default, 1, 1)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZainRizvi pushed a commit that referenced this pull request Apr 19, 2023
@kiszk @ZainRizvi
[quantized] Fix return values of _get_name() in quantized ConvTranspo…
12603bb 
…se (#97678)

This PR fixes incorrect return values of _get_name() in quantized `ConvTranspose?d`.

Pull Request resolved: #97678
Approved by: https://github.com/vkuzo, https://github.com/kit1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit1980 kit1980 kit1980 approved these changes

@vkuzo vkuzo vkuzo approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: quantization Quantization support in PyTorch open source release notes: AO frontend triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kiszk @kit1980 @pytorchmergebot @vkuzo @pytorchbot @drisspg