[Vulkan] Add convert_qconv2d_context op #97714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97714
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 FailuresAs of commit 0bcd08f: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D41595032 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41595032 |
manuelcandales
added a commit
to manuelcandales/pytorch
that referenced
this pull request
Mar 27, 2023
Summary: Pull Request resolved: pytorch#97714 This diffs adds a convert_qconv2d_context op, which converts a cpu quantized Conv2dPackedParamsBase object (used by quantized::conv2d) into a vulkan Conv2dPackedContext object. This op is used in a later diff (D44189363), to do a graph rewrite of quantized conv2d and conv2d_relu ops Test Plan: On Mac ``` cd ~/fbsource buck1 run -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAppleMac\#macosx-arm64 ``` On Android ``` cd ~/fbsource buck1 build -c ndk.custom_libcxx=false -c pt.enable_qpl=0 -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAndroid\#android-arm64 --show-output adb push buck-out/gen/xplat/caffe2/pt_vulkan_quantized_api_test_binAndroid\#android-arm64 /data/local/tmp/vulkan_quantized_api_test adb shell "/data/local/tmp/vulkan_quantized_api_test" ``` Reviewed By: SS-JIA Differential Revision: D41595032 fbshipit-source-id: b0368e24a4691168592eb608aa78ba3d26651b55
manuelcandales
force-pushed
the
export-D41595032
branch
from
c1bc29d
to
7272bc1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41595032 |
manuelcandales
added a commit
to manuelcandales/pytorch
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: pytorch#97714 This diffs adds a convert_qconv2d_context op, which converts a cpu quantized Conv2dPackedParamsBase object (used by quantized::conv2d) into a vulkan Conv2dPackedContext object. This op is used in a later diff (D44189363), to do a graph rewrite of quantized conv2d and conv2d_relu ops Test Plan: On Mac ``` cd ~/fbsource buck1 run -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAppleMac\#macosx-arm64 ``` On Android ``` cd ~/fbsource buck1 build -c ndk.custom_libcxx=false -c pt.enable_qpl=0 -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAndroid\#android-arm64 --show-output adb push buck-out/gen/xplat/caffe2/pt_vulkan_quantized_api_test_binAndroid\#android-arm64 /data/local/tmp/vulkan_quantized_api_test adb shell "/data/local/tmp/vulkan_quantized_api_test" ``` Reviewed By: SS-JIA Differential Revision: D41595032 fbshipit-source-id: 4329fc5a54a1e320e6d84f97c0e105f14b0b2698
manuelcandales
force-pushed
the
export-D41595032
branch
from
7272bc1
to
5c5f697
Compare
manuelcandales
added a commit
to manuelcandales/pytorch
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: pytorch#97714 This diffs adds a convert_qconv2d_context op, which converts a cpu quantized Conv2dPackedParamsBase object (used by quantized::conv2d) into a vulkan Conv2dPackedContext object. This op is used in a later diff (D44189363), to do a graph rewrite of quantized conv2d and conv2d_relu ops Test Plan: On Mac ``` cd ~/fbsource buck1 run -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAppleMac\#macosx-arm64 ``` On Android ``` cd ~/fbsource buck1 build -c ndk.custom_libcxx=false -c pt.enable_qpl=0 -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAndroid\#android-arm64 --show-output adb push buck-out/gen/xplat/caffe2/pt_vulkan_quantized_api_test_binAndroid\#android-arm64 /data/local/tmp/vulkan_quantized_api_test adb shell "/data/local/tmp/vulkan_quantized_api_test" ``` Reviewed By: SS-JIA Differential Revision: D41595032 fbshipit-source-id: d59d1cc2f9c7d203e10181e9f3fac236d412f0fd
manuelcandales
force-pushed
the
export-D41595032
branch
from
5c5f697
to
5a4fe51
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41595032 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41595032 |
manuelcandales
added a commit
to manuelcandales/pytorch
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: pytorch#97714 This diffs adds a convert_qconv2d_context op, which converts a cpu quantized Conv2dPackedParamsBase object (used by quantized::conv2d) into a vulkan Conv2dPackedContext object. This op is used in a later diff (D44189363), to do a graph rewrite of quantized conv2d and conv2d_relu ops Test Plan: On Mac ``` cd ~/fbsource buck1 run -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAppleMac\#macosx-arm64 ``` On Android ``` cd ~/fbsource buck1 build -c ndk.custom_libcxx=false -c pt.enable_qpl=0 -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAndroid\#android-arm64 --show-output adb push buck-out/gen/xplat/caffe2/pt_vulkan_quantized_api_test_binAndroid\#android-arm64 /data/local/tmp/vulkan_quantized_api_test adb shell "/data/local/tmp/vulkan_quantized_api_test" ``` Reviewed By: SS-JIA Differential Revision: D41595032 fbshipit-source-id: 6f9408c3ea7f90838704a28db5a9002c8725ccf7
manuelcandales
force-pushed
the
export-D41595032
branch
from
5a4fe51
to
9c12a98
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41595032 |
manuelcandales
added a commit
to manuelcandales/pytorch
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: pytorch#97714 This diffs adds a convert_qconv2d_context op, which converts a cpu quantized Conv2dPackedParamsBase object (used by quantized::conv2d) into a vulkan Conv2dPackedContext object. This op is used in a later diff (D44189363), to do a graph rewrite of quantized conv2d and conv2d_relu ops Test Plan: On Mac ``` cd ~/fbsource buck1 run -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAppleMac\#macosx-arm64 ``` On Android ``` cd ~/fbsource buck1 build -c ndk.custom_libcxx=false -c pt.enable_qpl=0 -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAndroid\#android-arm64 --show-output adb push buck-out/gen/xplat/caffe2/pt_vulkan_quantized_api_test_binAndroid\#android-arm64 /data/local/tmp/vulkan_quantized_api_test adb shell "/data/local/tmp/vulkan_quantized_api_test" ``` Reviewed By: SS-JIA Differential Revision: D41595032 fbshipit-source-id: c5740afb0510b84eac08cc0445b3de38b7734631
manuelcandales
force-pushed
the
export-D41595032
branch
2 times, most recently
from
e9f3a9b
to
1f2e74f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41595032 |
manuelcandales
added a commit
to manuelcandales/pytorch
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: pytorch#97714 This diffs adds a convert_qconv2d_context op, which converts a cpu quantized Conv2dPackedParamsBase object (used by quantized::conv2d) into a vulkan Conv2dPackedContext object. This op is used in a later diff (D44189363), to do a graph rewrite of quantized conv2d and conv2d_relu ops Test Plan: On Mac ``` cd ~/fbsource buck1 run -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAppleMac\#macosx-arm64 ``` On Android ``` cd ~/fbsource buck1 build -c ndk.custom_libcxx=false -c pt.enable_qpl=0 -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAndroid\#android-arm64 --show-output adb push buck-out/gen/xplat/caffe2/pt_vulkan_quantized_api_test_binAndroid\#android-arm64 /data/local/tmp/vulkan_quantized_api_test adb shell "/data/local/tmp/vulkan_quantized_api_test" ``` Reviewed By: SS-JIA Differential Revision: D41595032 fbshipit-source-id: 7502a0fa076b8ee7014f387508e1f5eb97788857
Summary: Pull Request resolved: pytorch#97714 This diffs adds a convert_qconv2d_context op, which converts a cpu quantized Conv2dPackedParamsBase object (used by quantized::conv2d) into a vulkan Conv2dPackedContext object. This op is used in a later diff (D44189363), to do a graph rewrite of quantized conv2d and conv2d_relu ops Test Plan: On Mac ``` cd ~/fbsource buck1 run -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAppleMac\#macosx-arm64 ``` On Android ``` cd ~/fbsource buck1 build -c ndk.custom_libcxx=false -c pt.enable_qpl=0 -c pt.vulkan_full_precision=1 //xplat/caffe2:pt_vulkan_quantized_api_test_binAndroid\#android-arm64 --show-output adb push buck-out/gen/xplat/caffe2/pt_vulkan_quantized_api_test_binAndroid\#android-arm64 /data/local/tmp/vulkan_quantized_api_test adb shell "/data/local/tmp/vulkan_quantized_api_test" ``` Reviewed By: SS-JIA Differential Revision: D41595032 fbshipit-source-id: fa1ae3e25237850b18c262891c6ae43d68ea8c7e
|
This pull request was exported from Phabricator. Differential Revision: D41595032 |
manuelcandales
force-pushed
the
export-D41595032
branch
from
1f2e74f
to
0bcd08f
Compare
SS-JIA
approved these changes
Mar 28, 2023
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diffs adds a convert_qconv2d_context op, which converts a cpu quantized Conv2dPackedParamsBase object (used by quantized::conv2d) into a vulkan Conv2dPackedContext object.
This op is used in a later diff (D44189363), to do a graph rewrite of quantized conv2d and conv2d_relu ops
Test Plan:
On Mac
On Android
Reviewed By: SS-JIA
Differential Revision: D41595032