[FSDP] Do not _unshard if already prefetched
#97981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97981
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c789061: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
awgu
added a commit
that referenced
this pull request
Mar 30, 2023
ghstack-source-id: d8149d2f96f14b8a60393371ce16c328264753ca Pull Request resolved: #97981
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Mar 30, 2023
ghstack-source-id: 9d76f160eb1e37ede7485773d6344e632a61042b Pull Request resolved: #97981
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Mar 30, 2023
ghstack-source-id: dd1c57e7790d0bca8ff3a780b17168391d60ba3a Pull Request resolved: #97981
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Mar 30, 2023
ghstack-source-id: b952c9ea2446a3d4c11e235854a169b60c41488d Pull Request resolved: #97981
awgu
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
kwen2501,
wanchaol,
fegin,
kiukchung and
d4l3k
as code owners
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Apr 3, 2023
awgu
added a commit
that referenced
this pull request
Apr 3, 2023
- This undoes #97981 due to a minor concern: The unshard logic (namely the `_use_unsharded_flat_parameter()` -> `_use_unsharded_views()` logic) for a handle depends on its own training state, not on that of the handle that prefetched it. Therefore, we actually want the handle itself to run `_use_unsharded_flat_parameter()`, not the handle that is prefetching. Otherwise, the handle could still be in `IDLE` but is being prefetched from another handle in `BACKWARD_PRE`, in which case the original handle does not correctly use the logic as if it were in `BACKWARD_PRE`. - Instead, we only run the `_use_unsharded_flat_parameter()` when the handle itself is running `unshard()`, which we differentiate using the `is_prefetch: bool` flag. [ghstack-poisoned]
This was referenced Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
_unshardif already prefetched #97981_runtime_utils.py#97980use_orig_params=True#97667FSDPParamInfoto useFlatParamHandle#97665use_orig_params: bool#97664