masked_scatter should accept only bool masks
#97999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97999
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5c98e02: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
the
module: cpu
|
I hope there won't be a SEV from byte removal, last time there was. |
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ngimel good point, importing internally to see what is going on |
ngimel
reviewed
Mar 30, 2023
malfet
changed the title
masked_scatter shoudl accept only bool masksmasked_scatter should accept only bool masks
Modify test_torch to check that assert is raised in this case torch.uint8 usage has been deprecated for a few releases, this diff finally removes it completely. Fixes #94634
malfet
force-pushed
the
malfet/allow-only-bool-mask-to-scatter
branch
from
e76fda5
to
5c98e02
Compare
ngimel
approved these changes
Apr 1, 2023
|
@pytorchbot merge -ic |
Merge startedYour change will be merged while ignoring the following 1 checks: Meta Internal-Only Changes Check Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify test_torch to check that assert is raised in this case
torch.uint8 usage has been deprecated for a few releases, and errors has been raised for other dtypes on CUDA device, but not on CPU.
This PR finally restricts mask to just
torch.boolSee #96594 as an example doing it for
torch.masked_fillFixes #94634
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @mikaylagawarecki