-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change torch._dynamo.export(aten_graph=...) to allow pre_autograd tracing #98031
Closed
Closed
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d7e356b
change torch._dynamo.export(aten_graph=...) to allow pre_autograd tra…
bdhirsh 9d694fa
Update on "change torch._dynamo.export(aten_graph=...) to allow pre_a…
bdhirsh b2de3a4
Update on "change torch._dynamo.export(aten_graph=...) to allow pre_a…
bdhirsh 423561f
Update on "change torch._dynamo.export(aten_graph=...) to allow pre_a…
bdhirsh b489623
Update on "change torch._dynamo.export(aten_graph=...) to allow pre_a…
bdhirsh b5ec040
Update on "change torch._dynamo.export(aten_graph=...) to allow pre_a…
bdhirsh b51acfb
Update on "change torch._dynamo.export(aten_graph=...) to allow pre_a…
bdhirsh 61c21be
Update on "change torch._dynamo.export(aten_graph=...) to allow pre_a…
bdhirsh 74d8e07
Update on "change torch._dynamo.export(aten_graph=...) to allow pre_a…
bdhirsh 172d7c1
Update on "change torch._dynamo.export(aten_graph=...) to allow pre_a…
bdhirsh 4653b55
Update on "change torch._dynamo.export(aten_graph=...) to allow pre_a…
bdhirsh 7f6bdb5
Update on "change torch._dynamo.export(aten_graph=...) to allow pre_a…
bdhirsh File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems surprising to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still waiting on explainer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sigh, wrote the comment when I initially made this update and forgot to submit it.
I'd be happy to make this a separate PR. The issue was that:
(1) We detach tensors as part of creating proxies.
(2) In pre_autograd tracing, we currently push
TorchProxyDispatchMode
onto both the autograd mode stack, and the original python key mode stack(3) The detach() calls get intercepted by the proxy mode on the original python key mode stack.
So we need to be careful that any aten ops that we call inside of TorchProxyDispatchMode happen in a
with inside_mode()
now.I think we agreed 2-3 weeks ago that we could avoid re-entrant issues if we solved the "fallthrough keys can't be intercepted by the python dispatcher" issue, but we agreed this is difficult.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok put this comment in the code?