Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torch/fx] add torch/utils/_stats.py to stack frame skiplist #98117

Closed
wants to merge 1 commit into from

Conversation

suo
Copy link
Member

@suo suo commented Apr 1, 2023

We added some @count decorators to stuff that show up now

🤖 Generated by Copilot at 0e503e8

Ignore torch/utils/_stats.py when tracing user frame in torch.fx.proxy. This avoids false source attribution for some profiling and debugging functions.

We added some @count decorators to stuff that show up now
@suo suo requested a review from SherlockNoMad April 1, 2023 01:53
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 1, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98117

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 Failures

As of commit 0e503e8:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Apr 1, 2023
@suo
Copy link
Member Author

suo commented Apr 3, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 3, 2023
@suo
Copy link
Member Author

suo commented Apr 4, 2023

@pytorchbot merge -f

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 4, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-f MESSAGE | -ic] [-r [{viable/strict,master}]]

Try @pytorchbot --help for more info.

@suo
Copy link
Member Author

suo commented Apr 4, 2023

@pytorchbot merge -f "merge mysteriously never completed?"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants