Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inductor] turn on vectorization with fallback for indirect indexing etc. #98138

Closed
wants to merge 6 commits into from

Conversation

jgong5
Copy link
Collaborator

@jgong5 jgong5 commented Apr 1, 2023

Stack from ghstack (oldest at bottom):

Always do vectorization with scalar fallback for indirect indexing right now. We can vectorize the indirect indexing load/store by analyzing how the indirect indices are related to the loop variables. This will be done in future PRs.

cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 1, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98138

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c15f08a:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…t indexing etc."


Always do vectorization with scalar fallback for indirect indexing right now. We can vectorize the indirect indexing load/store by analyzing how the indirect indices are related to the loop variables. This will be done in future PRs.

cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
jgong5 added a commit that referenced this pull request Apr 1, 2023
…etc.

ghstack-source-id: d9b5615bbf496abbd32124d34c00f77c26992601
Pull Request resolved: #98138
…t indexing etc."


Always do vectorization with scalar fallback for indirect indexing right now. We can vectorize the indirect indexing load/store by analyzing how the indirect indices are related to the loop variables. This will be done in future PRs.

cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
jgong5 added a commit that referenced this pull request Apr 2, 2023
…etc.

ghstack-source-id: bb61e29eae1d3c67da07e19eba4c9dfb552a3f92
Pull Request resolved: #98138
…t indexing etc."


Always do vectorization with scalar fallback for indirect indexing right now. We can vectorize the indirect indexing load/store by analyzing how the indirect indices are related to the loop variables. This will be done in future PRs.

cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
jgong5 added a commit that referenced this pull request Apr 6, 2023
…etc.

ghstack-source-id: ac152a69905db6c211572327ba3d71cddc6291aa
Pull Request resolved: #98138
@jgong5 jgong5 marked this pull request as ready for review April 6, 2023 13:07
@jgong5 jgong5 requested review from jansel and desertfire April 6, 2023 13:08
…t indexing etc."


Always do vectorization with scalar fallback for indirect indexing right now. We can vectorize the indirect indexing load/store by analyzing how the indirect indices are related to the loop variables. This will be done in future PRs.

cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
jgong5 added a commit that referenced this pull request Apr 7, 2023
…etc.

ghstack-source-id: cd2f9b31c59b651b9c36132292951abde19d63e6
Pull Request resolved: #98138
…t indexing etc."


Always do vectorization with scalar fallback for indirect indexing right now. We can vectorize the indirect indexing load/store by analyzing how the indirect indices are related to the loop variables. This will be done in future PRs.

cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
jgong5 added a commit that referenced this pull request Apr 7, 2023
…etc.

ghstack-source-id: 2e2e501b0f7d79be36647cb420824085b0f481d4
Pull Request resolved: #98138
@jgong5 jgong5 added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Apr 8, 2023
@jgong5
Copy link
Collaborator Author

jgong5 commented Apr 8, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit to crcrpar/pytorch that referenced this pull request Apr 8, 2023
…etc. (pytorch#98138)

Always do vectorization with scalar fallback for indirect indexing right now. We can vectorize the indirect indexing load/store by analyzing how the indirect indices are related to the loop variables. This will be done in future PRs.

Pull Request resolved: pytorch#98138
Approved by: https://github.com/jansel
skotapati pushed a commit to kulinseth/pytorch that referenced this pull request Apr 10, 2023
…etc. (pytorch#98138)

Always do vectorization with scalar fallback for indirect indexing right now. We can vectorize the indirect indexing load/store by analyzing how the indirect indices are related to the loop variables. This will be done in future PRs.

Pull Request resolved: pytorch#98138
Approved by: https://github.com/jansel
ZainRizvi pushed a commit that referenced this pull request Apr 19, 2023
…etc. (#98138)

Always do vectorization with scalar fallback for indirect indexing right now. We can vectorize the indirect indexing load/store by analyzing how the indirect indices are related to the loop variables. This will be done in future PRs.

Pull Request resolved: #98138
Approved by: https://github.com/jansel
@facebook-github-bot facebook-github-bot deleted the gh/jgong5/16/head branch June 8, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants