[FSDP][Docs] Add warning about forward saving param refs #98320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98320
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3b1d155: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (sharded)
This was referenced Apr 4, 2023
awgu
added a commit
that referenced
this pull request
Apr 4, 2023
ghstack-source-id: cd0567128342c6d3dc0985ced024b15d70c31439 Pull Request resolved: #98320
awgu
added
module: docs
This PR adds a warning following an issue hit by an internal user. [ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Apr 4, 2023
ghstack-source-id: 2ea672dc887cf403717c55bb66781e21606ab63c Pull Request resolved: #98320
awgu
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
kwen2501,
wanchaol,
fegin,
kiukchung and
d4l3k
as code owners
rohan-varma
approved these changes
Apr 4, 2023
awgu
added
ciflow/trunk
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ZainRizvi
pushed a commit
that referenced
this pull request
Apr 19, 2023
This PR adds a warning following an issue hit by an internal user. Pull Request resolved: #98320 Approved by: https://github.com/rohan-varma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
requires_grad_mask#98299_use_sharded_views()forSHARD_GRAD_OP#98250requires_gradforuse_orig_params=True#98221This PR adds a warning following an issue hit by an internal user.