Only print guard code when printing guards #98347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98347
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit dfc104e: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added a commit
that referenced
this pull request
Apr 4, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: c54de824b43775d1db0ad867b94059c8a6351ee8 Pull Request resolved: #98347
github-actions
bot
requested review from
miladm,
SherlockNoMad,
voznesenskym and
wconstab
Before: <img width="1138" alt="image" src="https://user-images.githubusercontent.com/13564/229915726-19bddea8-8fa4-46d2-8501-358e9f9ea639.png"> After: ``` [2023-04-04 13:44:23,109] torch._dynamo.convert_frame.__guards: [DEBUG] GUARDS: ___check_obj_id(L['self'], 139844089003936) not ___are_deterministic_algorithms_enabled() ``` Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Apr 4, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 521b4b9b92941559c3c2b030229a72d29fd955c6 Pull Request resolved: #98347
voznesenskym
approved these changes
Apr 4, 2023
Before: <img width="1138" alt="image" src="https://user-images.githubusercontent.com/13564/229915726-19bddea8-8fa4-46d2-8501-358e9f9ea639.png"> After: ``` [2023-04-04 13:44:23,109] torch._dynamo.convert_frame.__guards: [DEBUG] GUARDS: ___check_obj_id(L['self'], 139844089003936) not ___are_deterministic_algorithms_enabled() ``` Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Apr 4, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: d074e4d8640b00948a02f0689da868afad46da5a Pull Request resolved: #98347
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ZainRizvi
pushed a commit
that referenced
this pull request
Apr 19, 2023
Before: <img width="1138" alt="image" src="https://user-images.githubusercontent.com/13564/229915726-19bddea8-8fa4-46d2-8501-358e9f9ea639.png"> After: ``` [2023-04-04 13:44:23,109] torch._dynamo.convert_frame.__guards: [DEBUG] GUARDS: ___check_obj_id(L['self'], 139844089003936) not ___are_deterministic_algorithms_enabled() ``` Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #98347 Approved by: https://github.com/voznesenskym
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Before:
After:
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire