Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUDA 12.1 workflows #98492

Closed
wants to merge 3 commits into from
Closed

Conversation

ptrblck
Copy link
Collaborator

@ptrblck ptrblck commented Apr 6, 2023

@ptrblck ptrblck requested a review from a team as a code owner April 6, 2023 10:15
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 6, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98492

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 92c725f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 6, 2023
@ptrblck ptrblck added ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/nightly Trigger all jobs we run nightly (nightly.yml) ciflow/binaries_conda Trigger binary build and upload jobs for conda on the PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR labels Apr 6, 2023
@ptrblck
Copy link
Collaborator Author

ptrblck commented Apr 7, 2023

Builds seem to work.
The conda test failures seem to be related to: pytorch/builder#1385
The manywheel tests fail with:

ERROR: Could not find a version that satisfies the requirement pytorch-triton==2.1.0+46672772b4 (from torch) (from versions: 0.0.1)
ERROR: No matching distribution found for pytorch-triton==2.1.0+46672772b4

as the needed URL is invalid: https://download.pytorch.org/whl/nightly/cu121

@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 10, 2023
@malfet
Copy link
Contributor

malfet commented Apr 11, 2023

Manually pushed pytorch-cuda for 12.1 to pytorch-nightly channel and pytorch-triton to https://download.pytorch.org/whl/nightly/cu121 and everything seems to be working now

@malfet
Copy link
Contributor

malfet commented Apr 11, 2023

@pytorchbot drci update

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 11, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: update

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@malfet
Copy link
Contributor

malfet commented Apr 11, 2023

@pytorchbot drci --help

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 11, 2023

PyTorchBot Help

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

In order to invoke the bot on your PR, include a line that starts with
@pytorchbot anywhere in a comment. That line will form the command; no
multi-line commands are allowed. 

Example:
    Some extra context, blah blah, wow this PR looks awesome

    @pytorchbot merge

optional arguments:
  -h, --help            Show this help message and exit.

command:
  {merge,revert,rebase,label,drci}
    merge               Merge a PR
    revert              Revert a PR
    rebase              Rebase a PR
    label               Add label to a PR
    drci                Update Dr. CI

Merge

usage: @pytorchbot merge [-f MESSAGE | -ic] [-r [{viable/strict,master}]]

Merge an accepted PR, subject to the rules in .github/merge_rules.json.
By default, this will wait for all required checks (lint, pull) to succeed before merging.

optional arguments:
  -f MESSAGE, --force MESSAGE
                        Merge without checking anything. This requires a reason for auditting purpose, for example:
                        @pytorchbot merge -f 'Minor update to fix lint. Expecting all PR tests to pass'
  -ic, --ignore-current
                        Merge while ignore the currently failing jobs.  If there are no pending checks, use -f/--force since this will fail.
  -r [{viable/strict,master}], --rebase [{viable/strict,master}]
                        Rebase the PR to re run checks before merging.  Accepts viable/strict or master as branch options and will default to viable/strict if not specified.

Revert

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Revert a merged PR. This requires that you are a Meta employee.

Example:
  @pytorchbot revert -m="This is breaking tests on trunk. hud.pytorch.org/" -c=nosignal

optional arguments:
  -m MESSAGE, --message MESSAGE
                        The reason you are reverting, will be put in the commit message. Must be longer than 3 words.
  -c {nosignal,ignoredsignal,landrace,weird,ghfirst}, --classification {nosignal,ignoredsignal,landrace,weird,ghfirst}
                        A machine-friendly classification of the revert reason.

Rebase

usage: @pytorchbot rebase [-s | -b BRANCH]

Rebase a PR. Rebasing defaults to the stable viable/strict branch of pytorch.
You must have write permissions to the repo to rebase a PR.

optional arguments:
  -s, --stable          [DEPRECATED] Rebase onto viable/strict
  -b BRANCH, --branch BRANCH
                        Branch you would like to rebase to

Label

usage: @pytorchbot label labels [labels ...]

Adds label to a PR

positional arguments:
  labels  Labels to add to given Pull Request

Dr CI

usage: @pytorchbot drci 

Update Dr. CI. Updates the Dr. CI comment on the PR in case it's gotten out of sync with actual CI results.

@malfet
Copy link
Contributor

malfet commented Apr 11, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 11, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase and merge by leaving the following comment on this PR:
@pytorchbot merge -r
Or just rebase by leaving @pytorchbot rebase comment

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Contributor

malfet commented Apr 11, 2023

@pytorchbot merge -f "this is fine"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZainRizvi pushed a commit that referenced this pull request Apr 19, 2023
pytorchmergebot pushed a commit that referenced this pull request Apr 28, 2023
Related: #98492
This PR enables Windows builds after the needed AMIs are ready.

CC @atalman

Pull Request resolved: #100268
Approved by: https://github.com/atalman, https://github.com/malfet
pytorchmergebot pushed a commit that referenced this pull request Apr 30, 2024
Reference: #98492

Co-authored-by: Andrey Talman <atalman@fb.com>
Pull Request resolved: #121684
Approved by: https://github.com/atalman
andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
Reference: pytorch#98492

Co-authored-by: Andrey Talman <atalman@fb.com>
Pull Request resolved: pytorch#121684
Approved by: https://github.com/atalman
petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
Reference: pytorch#98492

Co-authored-by: Andrey Talman <atalman@fb.com>
Pull Request resolved: pytorch#121684
Approved by: https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries_conda Trigger binary build and upload jobs for conda on the PR ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/nightly Trigger all jobs we run nightly (nightly.yml) ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants