Rename assert options, turn off by default #98616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98616
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1673c99: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
eellison
added a commit
that referenced
this pull request
Apr 7, 2023
ghstack-source-id: cabe6880f502a2ff483ef0da6e8ecefbee12f264 Pull Request resolved: #98616
davidberard98
approved these changes
Apr 7, 2023
Neilblaze
approved these changes
Apr 7, 2023
Rename the runtime assert checking options to be more clear. Also turn off the slow path checking, since it is slow enough to significantly affect our compilation time speed in dashboard. cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
eellison
added a commit
that referenced
this pull request
Apr 7, 2023
ghstack-source-id: 4bc10f73b32f42bd6e757baab9c57313a6c3c44f Pull Request resolved: #98616
Rename the runtime assert checking options to be more clear. Also turn off the slow path checking, since it is slow enough to significantly affect our compilation time speed in dashboard. cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
eellison
added a commit
that referenced
this pull request
Apr 7, 2023
ghstack-source-id: 3ef7831b9f386045a3d80db47be2dec072587d93 Pull Request resolved: #98616
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
to crcrpar/pytorch
that referenced
this pull request
Apr 8, 2023
Rename the runtime assert checking options to be more clear. Also turn off the slow path checking, since it is slow enough to significantly affect our compilation time speed in dashboard. Pull Request resolved: pytorch#98616 Approved by: https://github.com/davidberard98, https://github.com/Neilblaze
skotapati
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Apr 10, 2023
Rename the runtime assert checking options to be more clear. Also turn off the slow path checking, since it is slow enough to significantly affect our compilation time speed in dashboard. Pull Request resolved: pytorch#98616 Approved by: https://github.com/davidberard98, https://github.com/Neilblaze
ZainRizvi
pushed a commit
that referenced
this pull request
Apr 19, 2023
Rename the runtime assert checking options to be more clear. Also turn off the slow path checking, since it is slow enough to significantly affect our compilation time speed in dashboard. Pull Request resolved: #98616 Approved by: https://github.com/davidberard98, https://github.com/Neilblaze
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Rename the runtime assert checking options to be more clear. Also turn off the slow path checking, since it is slow enough to significantly affect our compilation time speed in dashboard.
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire