fix scalar-tensor issue with CrossEntropyLoss label smoothing, symintify #98848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
github-actions
bot
requested review from
albanD,
antoniojkim,
ezyang,
jbschlosser,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
bdhirsh
added a commit
that referenced
this pull request
Apr 11, 2023
ghstack-source-id: ca62bba285fce2d500ed8f369da79949d32bb212 Pull Request resolved: #98848
This PR needs a labelIf your changes are user facing and intended to be a part of release notes, please use a label starting with If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see |
ezyang
reviewed
Apr 11, 2023
| @@ -369,8 +369,7 @@ static inline Tensor scalarToTensor( | |||
| const TensorOptions& options, | |||
| const at::Device& self_device) { | |||
| if (self_device == at::kCPU) { | |||
| return at::detail::scalar_tensor_static( | |||
| v, options.dtype_opt()->toScalarType(), self_device); | |||
| return at::scalar_tensor(v, options.device(self_device)); | |||
There was a problem hiding this comment.
seems like you've lost the dtype here
|
Everything else looks good, but you need to fix ci |
…ing, symintify" Fixes the fake tensor (and symint) issues with #98571. In particular, `at::detail::scalar_tensor_static()` seems like a footgun when used in code that needs to be traceable, so we may want to audit its usages more carefully. cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Apr 12, 2023
ghstack-source-id: 5b17d54a9e6a509bb5c354205d7f4135b93dc284 Pull Request resolved: #98848
…ing, symintify" Fixes the fake tensor (and symint) issues with #98571. In particular, `at::detail::scalar_tensor_static()` seems like a footgun when used in code that needs to be traceable, so we may want to audit its usages more carefully. cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Apr 12, 2023
ghstack-source-id: 2f848b3e484e3b6cca1ba1b70808ec0fd31922c3 Pull Request resolved: #98848
…ing, symintify" Fixes the fake tensor (and symint) issues with #98571. In particular, `at::detail::scalar_tensor_static()` seems like a footgun when used in code that needs to be traceable, so we may want to audit its usages more carefully. cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Apr 12, 2023
ghstack-source-id: 0139f6fc215458862d6be830628052020843612c Pull Request resolved: #98848
…ing, symintify" Fixes the fake tensor (and symint) issues with #98571. In particular, `at::detail::scalar_tensor_static()` seems like a footgun when used in code that needs to be traceable, so we may want to audit its usages more carefully. cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Apr 13, 2023
ghstack-source-id: 4dfba505f766e5a43dcbdd93106b0978cd2988d1 Pull Request resolved: #98848
…ing, symintify" Fixes the fake tensor (and symint) issues with #98571. In particular, `at::detail::scalar_tensor_static()` seems like a footgun when used in code that needs to be traceable, so we may want to audit its usages more carefully. cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Apr 13, 2023
ghstack-source-id: 0980f1bd53adf7b8fae9f06f9666d9fc5d8e03e7 Pull Request resolved: #98848
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the fake tensor (and symint) issues with #98571.
In particular,
at::detail::scalar_tensor_static()seems like a footgun when used in code that needs to be traceable, so we may want to audit its usages more carefully.Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @soumith @desertfire