[pt2] recursive IR check #98887
Closed
[pt2] recursive IR check #98887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98887
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 45b31a6: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D44809096 |
wconstab
approved these changes
Apr 11, 2023
|
This pull request was exported from Phabricator. Differential Revision: D44809096 |
xw285cornell
added a commit
to xw285cornell/pytorch
that referenced
this pull request
Apr 11, 2023
Summary: Pull Request resolved: pytorch#98887 IR check needs to be recursive to accommodate Tuple[Tensor, Tuple[Tensor]] schema Test Plan: Run the repro cmd and make sure it no longer fails TORCH_SHOW_CPP_STACKTRACES=1 TORCH_LOGS="+dynamo,aot,inductor" buck2 run mode/opt scripts/ml_model_exploration/coffee:defi_local -- --baseline_model_entity_id 421946503 --meta_ids '{"union_meta":422685721}' -g -t -l --model_type mimo_ctr_mbl_feed Differential Revision: D44809096 fbshipit-source-id: 4a1741a7e47619fc0591b6cbacfc13816d990936
xw285cornell
force-pushed
the
export-D44809096
branch
from
66f83e3
to
fae051a
Compare
Summary: Pull Request resolved: pytorch#98887 IR check needs to be recursive to accommodate Tuple[Tensor, Tuple[Tensor]] schema Test Plan: Run the repro cmd and make sure it no longer fails TORCH_SHOW_CPP_STACKTRACES=1 TORCH_LOGS="+dynamo,aot,inductor" buck2 run mode/opt scripts/ml_model_exploration/coffee:defi_local -- --baseline_model_entity_id 421946503 --meta_ids '{"union_meta":422685721}' -g -t -l --model_type mimo_ctr_mbl_feed Differential Revision: D44809096 fbshipit-source-id: 2beea0ba91e22a62a00df12cc59645e84cfc1dd3
|
This pull request was exported from Phabricator. Differential Revision: D44809096 |
xw285cornell
force-pushed
the
export-D44809096
branch
from
fae051a
to
45b31a6
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ZainRizvi
pushed a commit
that referenced
this pull request
Apr 19, 2023
Summary: IR check needs to be recursive to accommodate Tuple[Tensor, Tuple[Tensor]] schema
Test Plan:
Run the repro cmd and make sure it no longer fails
TORCH_SHOW_CPP_STACKTRACES=1 TORCH_LOGS="+dynamo,aot,inductor" buck2 run mode/opt scripts/ml_model_exploration/coffee:defi_local -- --baseline_model_entity_id 421946503 --meta_ids '{"union_meta":422685721}' -g -t -l --model_type mimo_ctr_mbl_feed
Differential Revision: D44809096
Pull Request resolved: #98887
Approved by: https://github.com/wconstab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: IR check needs to be recursive to accommodate Tuple[Tensor, Tuple[Tensor]] schema
Test Plan:
Run the repro cmd and make sure it no longer fails
TORCH_SHOW_CPP_STACKTRACES=1 TORCH_LOGS="+dynamo,aot,inductor" buck2 run mode/opt scripts/ml_model_exploration/coffee:defi_local -- --baseline_model_entity_id 421946503 --meta_ids '{"union_meta":422685721}' -g -t -l --model_type mimo_ctr_mbl_feed
Differential Revision: D44809096
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire