Apply static policy correctly to unspec #98983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98983
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cfc7735: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
ezyang,
jbschlosser,
miladm,
SherlockNoMad and
wconstab
voznesenskym
added a commit
that referenced
this pull request
Apr 12, 2023
ghstack-source-id: 131c0c438720e7ced970d81f80f6d392e490860a Pull Request resolved: #98983
ezyang
changed the title
ezyang
approved these changes
Apr 12, 2023
torch/_subclasses/meta_utils.py
Outdated
| shape_env, | ||
| callback, | ||
| source=AttrSource(source, "_base"), | ||
| dynamic_dims=[DimDynamic.STATIC] * t._base.dim(), |
There was a problem hiding this comment.
Worth a comment here about it
|
CI said no lol, time to look bleh, I bet it's shape_env is None when we are passing some dims in as dynamic static. |
cc soumith penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Apr 13, 2023
ghstack-source-id: 90862f38b31dd7c7cd6113c666191c522e232a30 Pull Request resolved: #98983 Logic for absent shape_env
cc soumith penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Apr 14, 2023
ghstack-source-id: 8c5c146295ce46a59780db336d8b68e1b8ba1b92 Pull Request resolved: #98983 Logic for absent shape_env Small test blips
cc soumith penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Apr 14, 2023
ghstack-source-id: fd947d76d628e1b34fd53855cfcbeda822c915fe Pull Request resolved: #98983 Logic for absent shape_env Small test blips Fixes Fixes
cc soumith penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Apr 14, 2023
ghstack-source-id: 5f5744506ec6c410387cd0a9d5343cf32a744da6 Pull Request resolved: #98983 Logic for absent shape_env Small test blips Fixes Fixes Fix test
cc soumith penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Apr 14, 2023
ghstack-source-id: 1c0b70def0087597cb98c821f67eb6880d2a0865 Pull Request resolved: #98983 Logic for absent shape_env Small test blips Fixes Fixes Fix test ugh
|
CI just looks like frame counts wobbling. |
cc soumith penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Apr 26, 2023
ghstack-source-id: eb4ab55f61c16031e5a732f66e744ce3bd69870b Pull Request resolved: #98983 Logic for absent shape_env Small test blips Fixes Fixes Fix test ugh test first Cleaner
cc soumith penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Apr 26, 2023
ghstack-source-id: 46cab563512141c3cb0cb2f4e34e04672cccae5c Pull Request resolved: #98983 Logic for absent shape_env Small test blips Fixes Fixes Fix test ugh test first Cleaner
cc soumith penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
cc soumith penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
cc soumith penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
Apr 30, 2023
ghstack-source-id: c466868d0b39d1eea57fa33d19495cab91361639 Pull Request resolved: #98983 Logic for absent shape_env Small test blips Fixes Fixes Fix test ugh test first Cleaner
cc soumith penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
voznesenskym
added a commit
that referenced
this pull request
May 1, 2023
ghstack-source-id: 2568cc1e4a85abc9673cf01d73d0a648ffb552a2 Pull Request resolved: #98983 Logic for absent shape_env Small test blips Fixes Fixes Fix test ugh test first Cleaner
cc soumith penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
ezyang
approved these changes
May 9, 2023
|
@pytorchbot merge |
ezyang
added a commit
that referenced
this pull request
May 9, 2023
ghstack-source-id: 6b2f09368ca9ed9d87e7ff608ea1674213de7721 Pull Request resolved: #98983 Logic for absent shape_env Small test blips Fixes Fixes Fix test ugh test first Cleaner
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: .github/workflows/trunk.yml / macos-12-py3-arm64 / test (default, 2, 3, macos-m1-12) Details for Dev Infra teamRaised by workflow job |
cc soumith penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
|
@pytorchbot merge |
ezyang
added a commit
that referenced
this pull request
May 10, 2023
ghstack-source-id: 460d1a8bf7dee25e9524d759d8eda42a64f03a9f Pull Request resolved: #98983 Logic for absent shape_env Small test blips Fixes Fixes Fix test ugh test first Cleaner
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @soumith @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire