Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable passing a dict of module names: log level to set_logs python api #98989

Closed
wants to merge 1 commit into from
Closed

Enable passing a dict of module names: log level to set_logs python api #98989

wants to merge 1 commit into from

Conversation

mlazos
Copy link
Contributor

@mlazos mlazos commented Apr 12, 2023 •
edited by pytorch-bot bot

Adds "module" kwarg to set_logs to allow a user to pass a dict of module qualified names to log level to the API.

cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 12, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98989

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7247aba:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mlazos mlazos changed the title Enable passing a dict of module names: log level to set logs_api Enable passing a dict of module names: log level to set_logs python api Apr 12, 2023
ezyang
ezyang approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is fine but I think I am also at the conclusion that the set_logs tons of kwargs API is just... not very good. Very inconvenient.

@mlazos
Copy link
Contributor Author

mlazos commented Apr 12, 2023

I guess this is fine but I think I am also at the conclusion that the set_logs tons of kwargs API is just... not very good. Very inconvenient.

Yeah I think I'm going to try a codegen thing. Let me see if autocomplete works on it, if not I'll just make it **kwargs, unless you have other ideas.

@mlazos
Copy link
Contributor Author

mlazos commented Apr 12, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 12, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@mlazos
Copy link
Contributor Author

mlazos commented Apr 13, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZainRizvi pushed a commit that referenced this pull request Apr 19, 2023
@mlazos @ZainRizvi
Enable passing a dict of module names: log level to set_logs python a…
69b46c6 
…pi (#98989)

Adds "module" kwarg to set_logs to allow a user to pass a dict of module qualified names to log level to the API.

Pull Request resolved: #98989
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@xw285cornell xw285cornell Awaiting requested review from xw285cornell

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: dynamo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mlazos @pytorchmergebot @ezyang