Update InternalMatch in subgraph_rewriter after repeated replacements #99039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99039
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d6dd464: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
sanchitintel
requested review from
wenzhe-nrv
and removed request for
EikanWang
angelayi
approved these changes
Apr 14, 2023
Co-authored-by: Angela Yi <angelayi@meta.com>
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ZainRizvi
pushed a commit
that referenced
this pull request
Apr 19, 2023
…#99039) Fixes #98974 When `torch.fx.subgraph_rewriter._replace_pattern` is used to remove nodes from a graph, if there are two adjacent matches then after the first removal, the nodes in `InternalMatch.nodes_map` and `placeholder_nodes` become outdated because they contain nodes that were just removed from the graph. This fix is to update the `match.nodes_map` and `match.placeholder_nodes` using the node changes stored in `match_changed_node`. Pull Request resolved: #99039 Approved by: https://github.com/angelayi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98974
When
torch.fx.subgraph_rewriter._replace_patternis used to remove nodes from a graph, if there are two adjacent matches then after the first removal, the nodes inInternalMatch.nodes_mapandplaceholder_nodesbecome outdated because they contain nodes that were just removed from the graph.This fix is to update the
match.nodes_mapandmatch.placeholder_nodesusing the node changes stored inmatch_changed_node.cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10