Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that while caching values we don't invoke any Aten operator #99050

Closed
wants to merge 1 commit into from
Closed

Make sure that while caching values we don't invoke any Aten operator #99050

wants to merge 1 commit into from

Conversation

qihqi
Copy link
Contributor

@qihqi qihqi commented Apr 13, 2023

Summary:
title
also change catch to catch all so we can make it wont fail

Test Plan: existing tests

Reviewed By: harishs88ss

Differential Revision: D44945942

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 13, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99050

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 86edae5:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Apr 13, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44945942

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44945942

qihqi added a commit to qihqi/pytorch that referenced this pull request Apr 13, 2023
@qihqi @facebook-github-bot
Make sure that while caching values we don't invoke any Aten operator (…
549d953 
…pytorch#99050)

Summary:
Pull Request resolved: pytorch#99050

title
also change catch to catch all so we can make it wont fail

Test Plan: existing tests

Reviewed By: harishs88ss

Differential Revision: D44945942

fbshipit-source-id: bed0c757b414f1e83f4394318bbf578ac082d5cc
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44945942

qihqi added a commit to qihqi/pytorch that referenced this pull request Apr 13, 2023
@qihqi @facebook-github-bot
Make sure that while caching values we don't invoke any Aten operator (…
e7ba2e5 
…pytorch#99050)

Summary:
Pull Request resolved: pytorch#99050

title
also change catch to catch all so we can make it wont fail

Test Plan: existing tests

Reviewed By: harishs88ss

Differential Revision: D44945942

fbshipit-source-id: 36218cf53f3db981b1fe1961b3701d60fff72e69
@qihqi @facebook-github-bot
Make sure that while caching values we don't invoke any Aten operator (…
86edae5 
…pytorch#99050)

Summary:
Pull Request resolved: pytorch#99050

title
also change catch to catch all so we can make it wont fail

Test Plan: existing tests

Reviewed By: harishs88ss

Differential Revision: D44945942

fbshipit-source-id: e2f32a011890315649c323ec260111cb7266861c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44945942

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 14, 2023
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZainRizvi pushed a commit that referenced this pull request Apr 19, 2023
@qihqi @ZainRizvi
Make sure that while caching values we don't invoke any Aten operator (…
e2ad993 
…#99050)

Summary:
title
also change catch to catch all so we can make it wont fail

Test Plan: existing tests

Reviewed By: harishs88ss

Differential Revision: D44945942

Pull Request resolved: #99050
Approved by: https://github.com/angelayi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelayi angelayi angelayi approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged merging release notes: jit release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qihqi @facebook-github-bot @pytorchmergebot @angelayi