Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't specialize when indexing by SymInt #99123

Closed
wants to merge 2 commits into from
Closed

Don't specialize when indexing by SymInt #99123

wants to merge 2 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Apr 14, 2023 •
edited by pytorch-bot bot

@ezyang
Don't specialize when indexing by SymInt
8396650 
Fixes #99091

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 14, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99123

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 792f21f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Apr 14, 2023
@ezyang
Don't specialize when indexing by SymInt
07bf71c 
Fixes #99091

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 24e8dee260fd7def62b559b03a2021defa9d8210
Pull Request resolved: #99123
@ezyang ezyang requested a review from msaroufim April 14, 2023 02:43
msaroufim
msaroufim approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@msaroufim msaroufim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ezyang
Copy link
Contributor Author

ezyang commented Apr 14, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 14, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ezyang
Update on "Don't specialize when indexing by SymInt"
792f21f 
Fixes #99091

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Apr 14, 2023
@ezyang
Don't specialize when indexing by SymInt
fb852e1 
Fixes #99091

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: c2de8d933389dbbbb8452c7dc2e1378851f1479c
Pull Request resolved: #99123
@ezyang
Copy link
Contributor Author

ezyang commented Apr 14, 2023

@pytorchbot merge -f "lintfix only"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZainRizvi pushed a commit that referenced this pull request Apr 19, 2023
@ezyang @ZainRizvi
Don't specialize when indexing by SymInt (#99123)
a08a01f 
Fixes #99091

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: #99123
Approved by: https://github.com/msaroufim
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1995/head branch June 8, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaroufim msaroufim msaroufim approved these changes

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: dynamo topic: bug fixes topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ezyang @pytorchmergebot @msaroufim