Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log_sigmoid_backward forward-AD #99288

Closed
wants to merge 2 commits into from
Closed

Conversation

qqaatw
Copy link
Collaborator

@qqaatw qqaatw commented Apr 17, 2023

Stack from ghstack (oldest at bottom):

Fixes #95057

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 17, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99288

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c41e998:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

qqaatw added a commit that referenced this pull request Apr 17, 2023
ghstack-source-id: a0f2c7cdafeb4c393c9c4059095ab035a49f02f9
Pull Request resolved: #99288
qqaatw added a commit that referenced this pull request Apr 17, 2023
ghstack-source-id: 0117e8e69b14c350587de8f46ee437a01d0fb75f
Pull Request resolved: #99288
@qqaatw qqaatw added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 17, 2023
@qqaatw qqaatw marked this pull request as ready for review April 17, 2023 14:19
Copy link
Collaborator

@kshitij12345 kshitij12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @qqaatw

@kshitij12345 kshitij12345 added the release notes: functorch release notes category; Pertaining to torch.func or pytorch/functorch label Apr 17, 2023
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@albanD
Copy link
Collaborator

albanD commented Apr 17, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZainRizvi pushed a commit that referenced this pull request Apr 19, 2023
@facebook-github-bot facebook-github-bot deleted the gh/qqaatw/16/head branch June 8, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged merging open source release notes: functorch release notes category; Pertaining to torch.func or pytorch/functorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants