Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print AOT Autograd graph name when accuracy failed #99366

Closed
wants to merge 3 commits into from
Closed

Print AOT Autograd graph name when accuracy failed #99366

wants to merge 3 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Apr 17, 2023 •
edited by pytorch-bot bot

@ezyang
Print AOT Autograd graph name when accuracy failed
9f4f615 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 17, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99366

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 712e8b0:

BROKEN TRUNK - The following jobs failed but were present on the merge base ccd5ad8:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Apr 17, 2023
@ezyang
Print AOT Autograd graph name when accuracy failed
610c788 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: c2494d8bd9fd825cb0b0568cecf7ca955451c976
Pull Request resolved: #99366
albanD
albanD approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM
Not sure why CI is failing.

@ezyang
Update on "Print AOT Autograd graph name when accuracy failed"
7044fbd 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Apr 18, 2023
@ezyang
Print AOT Autograd graph name when accuracy failed
056ccde 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: d151ff18ce38e1b8ae16f4a23ae230ce11056561
Pull Request resolved: #99366
@ezyang
Copy link
Contributor Author

ezyang commented Apr 18, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 18, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ezyang
Copy link
Contributor Author

ezyang commented Apr 19, 2023

@pytorchbot merge -f "failure is unrelated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 056ccde59f85d410e1571efafa1a39cb1d6a0b68 returned non-zero exit code 1

Auto-merging torch/_dynamo/debug_utils.py
CONFLICT (content): Merge conflict in torch/_dynamo/debug_utils.py
error: could not apply 056ccde59f8... Print AOT Autograd graph name when accuracy failed
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

@ezyang
Update on "Print AOT Autograd graph name when accuracy failed"
712e8b0 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Apr 20, 2023

@pytorchbot merge

ezyang added a commit that referenced this pull request Apr 20, 2023
@ezyang
Print AOT Autograd graph name when accuracy failed
fe57767 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: bc335ef7657ef28042665fc04f3c49a67e7ae321
Pull Request resolved: #99366
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/2004/head branch June 8, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@bdhirsh bdhirsh bdhirsh approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged merging module: dynamo release notes: dynamo topic: bug fixes topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ezyang @pytorchmergebot @albanD @bdhirsh