Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vmap] Add max_pool3d batch rule #99522

Closed
wants to merge 4 commits into from
Closed

Conversation

qqaatw
Copy link
Collaborator

@qqaatw qqaatw commented Apr 19, 2023

Stack from ghstack (oldest at bottom):

Also add a helper to integrate max_pool2d_with_indices and max_pool3d_with_indices

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 19, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99522

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 72187b0:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

qqaatw added a commit that referenced this pull request Apr 19, 2023
ghstack-source-id: 284e35ec31d67a1b6e24ff7f64e35a316df3bf15
Pull Request resolved: #99522
Also add a helper to integrate `max_pool2d_with_indices` and `max_pool3d_with_indices`



[ghstack-poisoned]
qqaatw added a commit that referenced this pull request Apr 19, 2023
ghstack-source-id: e11450cae1a808049873a8aa9b1babccd94e9ba4
Pull Request resolved: #99522
Also add a helper to integrate `max_pool2d_with_indices` and `max_pool3d_with_indices`



[ghstack-poisoned]
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@qqaatw qqaatw added the release notes: functorch release notes category; Pertaining to torch.func or pytorch/functorch label Apr 19, 2023
Also add a helper to integrate `max_pool2d_with_indices` and `max_pool3d_with_indices`



[ghstack-poisoned]
@facebook-github-bot facebook-github-bot deleted the gh/qqaatw/19/head branch June 8, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged open source release notes: functorch release notes category; Pertaining to torch.func or pytorch/functorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants