Travis CI: Run flake on Python 2.7 and 3.7 #9953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flake8 will produce different results on Python 2 and 3. Python 3.7 has __async__ as a reserved word pytorch#4999.
soumith
approved these changes
Jul 27, 2018
There was a problem hiding this comment.
soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Flake8 will produce different results on Python 2 and 3. Python 3.7 has __async__ as a reserved word pytorch#4999. Pull Request resolved: pytorch#9953 Differential Revision: D9035415 Pulled By: soumith fbshipit-source-id: 8a46e028a2e20a7e3f6d90137020268d65a7cc64
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Flake8 will produce different results on Python 2 and 3. Python 3.7 has __async__ as a reserved word pytorch#4999. Pull Request resolved: pytorch#9953 Differential Revision: D9035415 Pulled By: soumith fbshipit-source-id: 8a46e028a2e20a7e3f6d90137020268d65a7cc64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flake8 will produce different results on Python 2 and 3. Python 3.7 has async as a reserved word #4999.