Guard on default device #99551
Closed
Guard on default device #99551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99551
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3ecb5ba: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added a commit
that referenced
this pull request
Apr 19, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 22014366b3045adae69eba323c9887e093eaca9b Pull Request resolved: #99551
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Apr 19, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: b3e45c8a057659d2e5e40616a8cc0b48c51c4baf Pull Request resolved: #99551
| @dataclasses.dataclass(frozen=True) | ||
| class DefaultDeviceSource(Source): | ||
| def name(self): | ||
| return "" |
There was a problem hiding this comment.
Just don't define it
There was a problem hiding this comment.
Actually, we can't notimplemented this, because of provided_guarded_object.
Okay.
voznesenskym
approved these changes
Apr 19, 2023
mlazos
approved these changes
Apr 19, 2023
|
Could be 1-3% regression, but also could be noise. |
Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Apr 20, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 38dfe23eb95eb05a47e103d89b6f9aaa4c210137 Pull Request resolved: #99551
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire