New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiler] Support HTML plot output for profiler export_memory_timeline API #99751
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99751
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 0ca38d7: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D45152735 |
Looks like the images didn't export properly: |
This pull request was exported from Phabricator. Differential Revision: D45152735 |
…ne API (pytorch#99751) Summary: Pull Request resolved: pytorch#99751 Support the file extension .html, which will include a PNG image of the plot embedded into an HTML file. This allows users to avoid processing the timeline manually in their own frontend UI. Test Plan: CI Tests Ran on resnet50 model and generated this html file w/ plot: See attached html file: {F954232276} Screenshot: {F954232469} Reviewed By: davidberard98 Differential Revision: D45152735 Pulled By: aaronenyeshi fbshipit-source-id: 2d26bf0dbd1d3a6eaa05f0c3fc94a5df3c1e7e99
c094a86
to
bc4fc27
Compare
…ne API (pytorch#99751) Summary: Pull Request resolved: pytorch#99751 Support the file extension .html, which will include a PNG image of the plot embedded into an HTML file. This allows users to avoid processing the timeline manually in their own frontend UI. Test Plan: CI Tests Ran on resnet50 model and generated this html file w/ plot: See attached html file: {F954232276} Screenshot: {F954232469} Reviewed By: davidberard98 Differential Revision: D45152735 Pulled By: aaronenyeshi fbshipit-source-id: 6b4f00678ee804b093391f5ba8150a526a4eed9c
bc4fc27
to
44a9c02
Compare
This pull request was exported from Phabricator. Differential Revision: D45152735 |
@pytorchmergebot merge |
This pull request was exported from Phabricator. Differential Revision: D45152735 |
…ne API (pytorch#99751) Summary: Pull Request resolved: pytorch#99751 Support the file extension .html, which will include a PNG image of the plot embedded into an HTML file. This allows users to avoid processing the timeline manually in their own frontend UI. Test Plan: CI Tests Ran on resnet50 model and generated this html file w/ plot: See attached html file: {F954232276} Screenshot: {F954232469} Reviewed By: davidberard98 Differential Revision: D45152735 Pulled By: aaronenyeshi fbshipit-source-id: 46f1a7257bad456caf55ad17cb49a4d88963eeaa
44a9c02
to
b805b18
Compare
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ne API (pytorch#99751) Summary: Pull Request resolved: pytorch#99751 Support the file extension .html, which will include a PNG image of the plot embedded into an HTML file. This allows users to avoid processing the timeline manually in their own frontend UI. Test Plan: CI Tests Ran on resnet50 model and generated this html file w/ plot: See attached html file: {F954232276} Screenshot: {F954232469} Reviewed By: davidberard98 Differential Revision: D45152735 Pulled By: aaronenyeshi fbshipit-source-id: d73b8e7dad9d11ee51e081fd3b95071dec6b3df0
This pull request was exported from Phabricator. Differential Revision: D45152735 |
b805b18
to
0ca38d7
Compare
Merge failedReason: New commits were pushed while merging. Please rerun the merge command. Details for Dev Infra teamRaised by workflow job |
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary:
Support the file extension .html, which will include a PNG image of the plot embedded into an HTML file.
This allows users to avoid processing the timeline manually in their own frontend UI.
Test Plan:
CI Tests
Ran on resnet50 model and generated this html file w/ plot:
See attached html file: {F954232276}
Screenshot: {F954232469}
Differential Revision: D45152735
Pulled By: aaronenyeshi
cc @robieta @chaekit @ngimel @nbcsm @guotuofeng @guyang3532 @gaoteng-git @tiffzhaofb @dzhulgakov @davidberard98