Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiler] Support HTML plot output for profiler export_memory_timeline API #99751

Closed
wants to merge 1 commit into from

Conversation

aaronenyeshi
Copy link
Member

@aaronenyeshi aaronenyeshi commented Apr 21, 2023

Summary:
Support the file extension .html, which will include a PNG image of the plot embedded into an HTML file.

This allows users to avoid processing the timeline manually in their own frontend UI.

Test Plan:
CI Tests

Ran on resnet50 model and generated this html file w/ plot:
See attached html file: {F954232276}
Screenshot: {F954232469}

Differential Revision: D45152735

Pulled By: aaronenyeshi

cc @robieta @chaekit @ngimel @nbcsm @guotuofeng @guyang3532 @gaoteng-git @tiffzhaofb @dzhulgakov @davidberard98

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 21, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99751

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 0ca38d7:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45152735

@aaronenyeshi
Copy link
Member Author

Looks like the images didn't export properly:
Ran on resnet50 model and generated this html file w/ plot:
Attached html file:
test_gpu_timeline.html.zip
Screenshot:
image

@aaronenyeshi aaronenyeshi added oncall: profiler profiler-related issues (cpu, gpu, kineto) release notes: profiler release notes category labels Apr 21, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45152735

aaronenyeshi added a commit to aaronenyeshi/pytorch that referenced this pull request Apr 21, 2023
…ne API (pytorch#99751)

Summary:
Pull Request resolved: pytorch#99751

Support the file extension .html, which will include a PNG image of the plot embedded into an HTML file.

This allows users to avoid processing the timeline manually in their own frontend UI.

Test Plan:
CI Tests

Ran on resnet50 model and generated this html file w/ plot:
See attached html file: {F954232276}
Screenshot: {F954232469}

Reviewed By: davidberard98

Differential Revision: D45152735

Pulled By: aaronenyeshi

fbshipit-source-id: 2d26bf0dbd1d3a6eaa05f0c3fc94a5df3c1e7e99
aaronenyeshi added a commit to aaronenyeshi/pytorch that referenced this pull request Apr 21, 2023
…ne API (pytorch#99751)

Summary:
Pull Request resolved: pytorch#99751

Support the file extension .html, which will include a PNG image of the plot embedded into an HTML file.

This allows users to avoid processing the timeline manually in their own frontend UI.

Test Plan:
CI Tests

Ran on resnet50 model and generated this html file w/ plot:
See attached html file: {F954232276}
Screenshot: {F954232469}

Reviewed By: davidberard98

Differential Revision: D45152735

Pulled By: aaronenyeshi

fbshipit-source-id: 6b4f00678ee804b093391f5ba8150a526a4eed9c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45152735

@aaronenyeshi
Copy link
Member Author

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 21, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45152735

aaronenyeshi added a commit to aaronenyeshi/pytorch that referenced this pull request Apr 21, 2023
…ne API (pytorch#99751)

Summary:
Pull Request resolved: pytorch#99751

Support the file extension .html, which will include a PNG image of the plot embedded into an HTML file.

This allows users to avoid processing the timeline manually in their own frontend UI.

Test Plan:
CI Tests

Ran on resnet50 model and generated this html file w/ plot:
See attached html file: {F954232276}
Screenshot: {F954232469}

Reviewed By: davidberard98

Differential Revision: D45152735

Pulled By: aaronenyeshi

fbshipit-source-id: 46f1a7257bad456caf55ad17cb49a4d88963eeaa
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

…ne API (pytorch#99751)

Summary:
Pull Request resolved: pytorch#99751

Support the file extension .html, which will include a PNG image of the plot embedded into an HTML file.

This allows users to avoid processing the timeline manually in their own frontend UI.

Test Plan:
CI Tests

Ran on resnet50 model and generated this html file w/ plot:
See attached html file: {F954232276}
Screenshot: {F954232469}

Reviewed By: davidberard98

Differential Revision: D45152735

Pulled By: aaronenyeshi

fbshipit-source-id: d73b8e7dad9d11ee51e081fd3b95071dec6b3df0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45152735

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@aaronenyeshi
Copy link
Member Author

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged oncall: profiler profiler-related issues (cpu, gpu, kineto) release notes: profiler release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants