[Doc] linalg.ldl_factor: render the Shape of tensor A #99777

isdanni · 2023-04-22T00:25:34Z

Summary: Fix: #96864

Test Plan: Please see GitHub tests.

pytorch-bot · 2023-04-22T00:25:38Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99777

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ 1 Unrelated Failure

As of commit 90a1625:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

linux-bionic-cuda12.1-py3.10-gcc9-bazel-test / build-and-test (default, 1, 1, linux.4xlarge.nvidia.gpu, unstable) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2023-04-22T00:26:17Z

This pull request was exported from Phabricator. Differential Revision: D45204660

facebook-github-bot · 2023-04-22T06:19:16Z

This pull request was exported from Phabricator. Differential Revision: D45204660

lezcano

Please, see the format that's used in the rest of linalg. In particular, we avoid using :math: as it takes quite a long time to render. Use single backticks instead.

facebook-github-bot · 2023-04-22T17:17:16Z

This pull request was exported from Phabricator. Differential Revision: D45204660

Summary: Pull Request resolved: pytorch#99777 Differential Revision: D45204660 fbshipit-source-id: 58006c20691e10733714b98a4b62e3c40482f46c

facebook-github-bot · 2023-04-22T19:31:07Z

This pull request was exported from Phabricator. Differential Revision: D45204660

Summary: Pull Request resolved: pytorch#99777 Differential Revision: D45204660 fbshipit-source-id: 74feb22215b595e1599d5fdfebfbf84a76acdaec

Summary: Pull Request resolved: pytorch#99777 Differential Revision: D45204660 fbshipit-source-id: 92789ab16ebea78ef0385db2020e4fd2a8bfda0c

facebook-github-bot · 2023-04-23T06:18:41Z

This pull request was exported from Phabricator. Differential Revision: D45204660

lezcano · 2023-04-23T12:35:59Z

torch/linalg/__init__.py

@@ -871,7 +871,8 @@
 """ + r"""

 Args:
-    A (Tensor): tensor of shape (*, n, n) where * is zero or more batch dimensions consisting of symmetric or Hermitian matrices.
+    A (Tensor): tensor of shape `(*, n, n)` where `*` is zero or more batch dimensions
+                    consisting of symmetric or Hermitian matrices.
                    `(*, n, n)` where `*` is one or more batch dimensions.


Feel free to delete this line as well, as it's repeated. Same in the other function.

Also, this line has extra indentation. Same in the other one

Summary: Pull Request resolved: pytorch#99777 Differential Revision: D45204660 fbshipit-source-id: a6e842c166a9b8d95e5f1d777ddd27654a35869b

facebook-github-bot · 2023-04-24T05:00:51Z

This pull request was exported from Phabricator. Differential Revision: D45204660

lezcano

Thank you!

github-actions · 2023-06-27T19:33:54Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

isdanni · 2023-06-27T20:16:41Z

@lezcano @IvanYashchuk any plans to merge this? :)

lezcano · 2023-06-28T04:14:48Z

You can merge it yourself writing @pytorchbot merge in a comment :)

isdanni · 2023-06-28T04:59:29Z

@pytorchbot merge

isdanni · 2023-06-28T05:02:31Z

@pytorchbot merge -r

pytorchmergebot · 2023-06-28T05:04:20Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-06-28T05:04:30Z

Successfully rebased export-D45204660 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout export-D45204660 && git pull --rebase)

Summary: Pull Request resolved: pytorch#99777 Differential Revision: D45204660 fbshipit-source-id: a6e842c166a9b8d95e5f1d777ddd27654a35869b

pytorchmergebot · 2023-06-28T05:05:35Z

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team

Raised by workflow job

isdanni · 2023-06-28T05:31:00Z

@pytorchbot merge -r

pytorchmergebot · 2023-06-28T05:32:45Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-06-28T05:32:49Z

Tried to rebase and push PR #99777, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

pytorchmergebot · 2023-06-28T05:33:54Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-06-28T05:34:00Z

Merge failed

Reason: 1 jobs have failed, first few of them are: Meta Internal-Only Changes Check

Details for Dev Infra team

Raised by workflow job

isdanni · 2023-06-28T05:42:01Z

@pytorchbot merge -f

pytorch-bot · 2023-06-28T05:42:02Z

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-f MESSAGE | -i] [-ic] [-r [{viable/strict,main}]]

Try @pytorchbot --help for more info.

isdanni · 2023-06-28T05:42:36Z

@pytorchbot merge -f "test failure unrelated"

pytorch-bot · 2023-06-28T05:42:39Z

You are not authorized to force merges to this repository. Please use the regular @pytorchmergebot merge command instead

Summary: Pull Request resolved: pytorch#99777 Differential Revision: D45204660 fbshipit-source-id: c797c01364df96b0b71073244527f45c8ddba3ea

facebook-github-bot · 2023-06-28T06:02:05Z

This pull request was exported from Phabricator. Differential Revision: D45204660

lezcano · 2023-06-28T06:02:31Z

Since you imported this, you should import the rebased branch onto phabricator as well, I believe.

isdanni · 2023-06-28T06:45:09Z

@pytorchbot merge

pytorchmergebot · 2023-06-28T06:46:57Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

isdanni requested review from lezcano and IvanYashchuk as code owners April 22, 2023 00:25

pytorch-bot bot added the release notes: linalg_frontend release notes category label Apr 22, 2023

facebook-github-bot added the fb-exported label Apr 22, 2023

isdanni force-pushed the export-D45204660 branch from 6f89712 to 38a7a57 Compare April 22, 2023 06:19

lezcano requested changes Apr 22, 2023

View reviewed changes

isdanni force-pushed the export-D45204660 branch from 38a7a57 to 60cf73d Compare April 22, 2023 17:17

isdanni force-pushed the export-D45204660 branch from 60cf73d to c258c84 Compare April 22, 2023 19:31

isdanni force-pushed the export-D45204660 branch from c258c84 to cfe8191 Compare April 23, 2023 06:18

lezcano reviewed Apr 23, 2023

View reviewed changes

isdanni force-pushed the export-D45204660 branch from cfe8191 to c0a4882 Compare April 24, 2023 05:00

lezcano approved these changes Apr 24, 2023

View reviewed changes

isdanni changed the title ~~[doc] linalg.ldl_factor: render the Shape of tensor A~~ [Doc] linalg.ldl_factor: render the Shape of tensor A Apr 28, 2023

github-actions bot added the Stale label Jun 27, 2023

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 28, 2023

pytorchmergebot force-pushed the export-D45204660 branch from c0a4882 to 192a6db Compare June 28, 2023 05:04

pytorchmergebot added the merging label Jun 28, 2023

pytorchmergebot removed the merging label Jun 28, 2023

pytorchmergebot added the merging label Jun 28, 2023

pytorchmergebot removed the merging label Jun 28, 2023

[doc] linalg.ldl_factor: render the Shape of tensor A (pytorch#99777)

90a1625

Summary: Pull Request resolved: pytorch#99777 Differential Revision: D45204660 fbshipit-source-id: c797c01364df96b0b71073244527f45c8ddba3ea

isdanni force-pushed the export-D45204660 branch from 192a6db to 90a1625 Compare June 28, 2023 06:02

pytorchmergebot added the merging label Jun 28, 2023

pytorchmergebot added Merged and removed merging labels Jun 28, 2023

pytorchmergebot closed this in 89fcfc1 Jun 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Doc] linalg.ldl_factor: render the Shape of tensor A #99777

[Doc] linalg.ldl_factor: render the Shape of tensor A #99777

isdanni commented Apr 22, 2023 •

edited

pytorch-bot bot commented Apr 22, 2023 •

edited

facebook-github-bot commented Apr 22, 2023

facebook-github-bot commented Apr 22, 2023

lezcano left a comment

facebook-github-bot commented Apr 22, 2023

facebook-github-bot commented Apr 22, 2023

facebook-github-bot commented Apr 23, 2023

lezcano Apr 23, 2023

lezcano Apr 23, 2023

facebook-github-bot commented Apr 24, 2023

lezcano left a comment

github-actions bot commented Jun 27, 2023

isdanni commented Jun 27, 2023

lezcano commented Jun 28, 2023

isdanni commented Jun 28, 2023

isdanni commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

isdanni commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

isdanni commented Jun 28, 2023

pytorch-bot bot commented Jun 28, 2023

isdanni commented Jun 28, 2023

pytorch-bot bot commented Jun 28, 2023

facebook-github-bot commented Jun 28, 2023

lezcano commented Jun 28, 2023

isdanni commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

[Doc] linalg.ldl_factor: render the Shape of tensor A #99777

[Doc] linalg.ldl_factor: render the Shape of tensor A #99777

Conversation

isdanni commented Apr 22, 2023 • edited

pytorch-bot bot commented Apr 22, 2023 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99777

✅ 1 Unrelated Failure

facebook-github-bot commented Apr 22, 2023

facebook-github-bot commented Apr 22, 2023

lezcano left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Apr 22, 2023

facebook-github-bot commented Apr 22, 2023

facebook-github-bot commented Apr 23, 2023

lezcano Apr 23, 2023

Choose a reason for hiding this comment

lezcano Apr 23, 2023

Choose a reason for hiding this comment

facebook-github-bot commented Apr 24, 2023

lezcano left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 27, 2023

isdanni commented Jun 27, 2023

lezcano commented Jun 28, 2023

isdanni commented Jun 28, 2023

isdanni commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

Merge failed

isdanni commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

Merge started

pytorchmergebot commented Jun 28, 2023

Merge failed

isdanni commented Jun 28, 2023

pytorch-bot bot commented Jun 28, 2023

isdanni commented Jun 28, 2023

pytorch-bot bot commented Jun 28, 2023

facebook-github-bot commented Jun 28, 2023

lezcano commented Jun 28, 2023

isdanni commented Jun 28, 2023

pytorchmergebot commented Jun 28, 2023

Merge started

isdanni commented Apr 22, 2023 •

edited

pytorch-bot bot commented Apr 22, 2023 •

edited