RFC-0013: View/Inplace handling on opaque tensors #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
zou3519
reviewed
Jul 7, 2021
Comment on lines
+1
to
+8
| ## Summary | ||
|
|
||
| In the ideal end state, dispatcher should be able to provide an opt-in | ||
| kernel to functionalize view & inplace ops. Currently we have a similar | ||
| infrastructure in pytorch/xla, but that’s only available on the lazy | ||
| traced graph. To make this elimination pass available to FX and Mobile | ||
| GPU like other backends that only support opaque tensor storage, this | ||
| pass should be lifted up to dispatcher level. |
There was a problem hiding this comment.
@ailzhang Ed tells me you have a prototype somewhere. Do you have a link to it and is it usable? I'm interested in trying it out on some functorch-related things. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @ailzhang
Rendered
Signed-off-by: Edward Z. Yang ezyang@fb.com