Skip to content

Commit

Permalink
[BugFix] Fix Ray collector on Python > 3.8 (#2015)
Browse files Browse the repository at this point in the history
  • Loading branch information
albertbou92 committed Mar 18, 2024
1 parent 77d2fc9 commit 87f3437
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions torchrl/collectors/collectors.py
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,9 @@ def __repr__(self) -> str:
string = f"{self.__class__.__name__}()"
return string

def __class_getitem__(self, index):
raise NotImplementedError


@accept_remote_rref_udf_invocation
class SyncDataCollector(DataCollectorBase):
Expand Down

1 comment on commit 87f3437

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'CPU Benchmark Results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 87f3437 Previous: 77d2fc9 Ratio
benchmarks/test_replaybuffer_benchmark.py::test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 325.3394862227474 iter/sec (stddev: 0.011821469949613608) 737.3859514592234 iter/sec (stddev: 0.00011417980866113422) 2.27

This comment was automatically generated by workflow using github-action-benchmark.

CC: @vmoens

Please sign in to comment.