Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] missing deprecated kwargs #2125

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[BugFix] missing deprecated kwargs #2125

merged 1 commit into from
Apr 26, 2024

Conversation

fedebotu
Copy link
Contributor

Description

The following code, passing the deprecated minimum and maximum:

from torchrl.data import BoundedTensorSpec

spec = BoundedTensorSpec(minimum=0, maximum=1, shape=(2,))

Raises the following error: AttributeError: 'BoundedTensorSpec' object has no attribute 'DEPRECATED_KWARGS'. This attribute was removed in a previous commit.

I simply modified the warning message to keep the current functionality!

Motivation and Context

(did not raise an issue since it is super simple and will only affect depracted usage of one tensor spec)

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Copy link

pytorch-bot bot commented Apr 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2125

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 26, 2024
fedebotu added a commit to ai4co/rl4co that referenced this pull request Apr 26, 2024
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vmoens vmoens merged commit 47bb3ef into pytorch:main Apr 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants