Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default handlers to support batching #2121

Open
lxning opened this issue Feb 10, 2023 · 0 comments
Open

Update default handlers to support batching #2121

lxning opened this issue Feb 10, 2023 · 0 comments
Labels
bug Something isn't working p0 high priority
Milestone

Comments

@lxning
Copy link
Collaborator

lxning commented Feb 10, 2023

馃悰 Describe the bug

The existing default handlers are not able to handle batching. Eg.

https://github.com/pytorch/serve/blob/master/ts/torch_handler/text_classifier.py#L49

The correct way should be sth like this.

Error logs

The error log example "number of batch response mismatched, expect: 3, got: 1."

Installation instructions

yes

Model Packaing

ref : same issue #

config.properties

No response

Versions

v0.7.1

Repro instructions

ref : same issue #2119

Possible Solution

No response

@lxning lxning added bug Something isn't working p0 high priority labels Feb 10, 2023
@lxning lxning added this to the v0.8.0 milestone Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p0 high priority
Projects
v0.8.0 lifecycle
Awaiting triage
Development

No branches or pull requests

1 participant