Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ update: international language decode #1393

Merged
merged 4 commits into from
Sep 9, 2022
Merged

FAQ update: international language decode #1393

merged 4 commits into from
Sep 9, 2022

Conversation

lxning
Copy link
Collaborator

@lxning lxning commented Jan 7, 2022

Description

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)
#1385

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the tests [UT/IT] that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • UT/IT execution results

  • Logs

Checklist:

  • Have you added tests that prove your fix is effective or that this feature works?
  • New and existing unit tests pass locally with these changes?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@lxning lxning added the documentation Improvements or additions to documentation label Jan 7, 2022
@lxning lxning added this to the v0.5.3 milestone Jan 7, 2022
@lxning lxning self-assigned this Jan 7, 2022
@lxning lxning added this to In Review in v0.5.3 lifecycle Jan 7, 2022
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-win
  • Commit ID: 6a6e343
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: 6a6e343
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: 6a6e343
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@lxning lxning moved this from In Review to Done in v0.5.3 lifecycle Feb 3, 2022
docs/FAQs.md Outdated
### How to decode international language in inference response on client side?
By default, Torchserve uses utf-8 to encode if the inference response is string. So client can use utf-8 to decode.

If a model converts international language string to bytes, client needs to use the codec mechanism specified by the model.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would an example help? Let's assume something like simplified chinese - how should people decode that within torchserve? Just change the post process handler to decode?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do see utf-8 decoding in some examples like the nmt one. We can probably add a reference here

@msaroufim
Copy link
Member

@maaquib I Just made your suggestion, can you check this PR again so we can merge?

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #1393 (7722667) into master (79e4e19) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1393   +/-   ##
=======================================
  Coverage   45.23%   45.23%           
=======================================
  Files          64       64           
  Lines        2602     2602           
  Branches       60       60           
=======================================
  Hits         1177     1177           
  Misses       1425     1425           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim merged commit 0bd217a into master Sep 9, 2022
jagadeeshi2i pushed a commit to jagadeeshi2i/serve that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants