-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAQ update: international language decode #1393
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
docs/FAQs.md
Outdated
### How to decode international language in inference response on client side? | ||
By default, Torchserve uses utf-8 to encode if the inference response is string. So client can use utf-8 to decode. | ||
|
||
If a model converts international language string to bytes, client needs to use the codec mechanism specified by the model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would an example help? Let's assume something like simplified chinese - how should people decode that within torchserve? Just change the post process handler to decode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do see utf-8 decoding in some examples like the nmt one. We can probably add a reference here
@maaquib I Just made your suggestion, can you check this PR again so we can merge? |
Codecov Report
@@ Coverage Diff @@
## master #1393 +/- ##
=======================================
Coverage 45.23% 45.23%
=======================================
Files 64 64
Lines 2602 2602
Branches 60 60
=======================================
Hits 1177 1177
Misses 1425 1425 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Description
Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
#1385
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the tests [UT/IT] that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
UT/IT execution results
Logs
Checklist: