Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate ci benchmark dir #1658

Merged
merged 5 commits into from
Aug 16, 2022
Merged

deprecate ci benchmark dir #1658

merged 5 commits into from
Aug 16, 2022

Conversation

lxning
Copy link
Collaborator

@lxning lxning commented May 27, 2022

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

PR deprecates benchmarks/automated directory, so ci/benchmark should be deprecated too.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@lxning lxning added benchmark p2 low priority labels May 27, 2022
@lxning lxning added this to the v0.6.1 milestone May 27, 2022
@lxning lxning requested review from maaquib and msaroufim May 27, 2022 01:01
@lxning lxning self-assigned this May 27, 2022
@msaroufim msaroufim added this to in review in v0.6.1 lifecycle Jun 15, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #1658 (bc686cb) into master (be6226d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1658   +/-   ##
=======================================
  Coverage   45.28%   45.28%           
=======================================
  Files          64       64           
  Lines        2597     2597           
  Branches       60       60           
=======================================
  Hits         1176     1176           
  Misses       1421     1421           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim merged commit f20388b into master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark p2 low priority
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants