-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow for pushing conda nightly binaries and merging all nightly runs to a single workflow #1685
Conversation
Thanks @ankithagunapal! I'm super glad to see this change. There's a few more things we need to do to merge this
|
@msaroufim Have updated the binaries to have a format (including date) which is consistent with other packages in pytorch. Updated yml file to use CONDA_NIGHTLY_TOKEN which will push the binaries to https://anaconda.org/pytorch-nightly/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor nits are left that that need to be fixed before merge
Also I'd like us to add instructions on the main README for installation for both regular and nightly conda https://github.com/pytorch/serve#-quick-start-with-torchserve
@agunapal conda binary is based on pypi. We already have pypi nightly build. To make pypi and conda binary consistent, I think they should be sit together; otherwise, it would potentially cause binary discrepancy and also waste resource. In other words, the existing pypi nightly build workflow is extended to add one more steps to build/release conda. |
That's a good point, I think we can actually unify the 3 actions we have for nightly torchserve, workflow-archiver and model-archiver into a single action and then add a step there to also do conda https://github.com/pytorch/serve/blob/master/.github/workflows/torchserve-nightly-build.yml |
Thanks @lxning Thats a good suggestion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 workflows have been merged to a single workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, let's just add some pypi binaries uploaded
Description
Merged torchserve-nightly, torch-model-archiver-nightly, torch-workflow-archiver and torchserve conda nightly
into 1 single flow.
Current Behavior:
Problem:
Solution:
The workflow does the following:
Miscellaneous:
Fixes #(issue)
Reduces developer time to build and push binaries
Type of change
Feature/Issue validation/testing
Test B
You can view all the uploaded files here
https://anaconda.org/agunapal/repo
Test C
Binary being updated with the latest date
Tested the binary on GPU as well
PyPI binaries test
PyPI binaries test
Checklist: