Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: volume permission in kubernetes setup #1747

Merged
merged 17 commits into from
Oct 3, 2022

Conversation

jagadeeshi2i
Copy link
Collaborator

@jagadeeshi2i jagadeeshi2i commented Jul 20, 2022

Signed-off-by: jagadeesh jagadeeshj@ideas2it.com

Description

Fixes security context issue while installing TS helm chart. The model-server user own the /home/model-server path where the volume is being mounted.

Fixes #1337
TS install output:
screenshot

TS pod describe output:
image

test.log

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] This change requires a documentation update

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
@jagadeeshi2i jagadeeshi2i changed the title [WIP] fix: volume permission in torchserve kubernetes [WIP] fix: volume permission in kubernetes setup Jul 20, 2022
@jagadeeshi2i jagadeeshi2i changed the title [WIP] fix: volume permission in kubernetes setup fix: volume permission in kubernetes setup Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1747 (1fa9371) into master (6b4dc84) will increase coverage by 3.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1747      +/-   ##
==========================================
+ Coverage   41.67%   44.95%   +3.28%     
==========================================
  Files          55       63       +8     
  Lines        2282     2609     +327     
  Branches        1       56      +55     
==========================================
+ Hits          951     1173     +222     
- Misses       1331     1436     +105     
Impacted Files Coverage Δ
...hiver/workflow_archiver/workflow_archiver_error.py 100.00% <0.00%> (ø)
...iver/workflow_archiver/workflow_packaging_utils.py 68.68% <0.00%> (ø)
...l-archiver/model_archiver/model_packaging_utils.py 54.96% <0.00%> (ø)
...el-archiver/model_archiver/model_archiver_error.py 100.00% <0.00%> (ø)
...w-archiver/workflow_archiver/workflow_packaging.py 89.65% <0.00%> (ø)
model-archiver/model_archiver/version.py 100.00% <0.00%> (ø)
workflow-archiver/workflow_archiver/version.py 100.00% <0.00%> (ø)
model-archiver/model_archiver/model_packaging.py 90.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jagadeeshi2i Could you please clarify in the description how this is fixing 1337 Also could you please clarify what I am supposed to look at in the test.log. Could you please share the before/after log?

@jagadeeshi2i
Copy link
Collaborator Author

jagadeeshi2i commented Jul 26, 2022

Hi @agunapal the securityContext fix is not required for native torchserve. As TS mount the PV in /home/model-server path which is owned by model-server. The fix was earlier added for other integration like kserve.

@msaroufim msaroufim requested review from agunapal and removed request for agunapal October 3, 2022 14:43
@msaroufim msaroufim merged commit 23a7671 into pytorch:master Oct 3, 2022
jagadeeshi2i added a commit to jagadeeshi2i/serve that referenced this pull request Nov 1, 2022
* fix: volume permission in torchserve kubernetes

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>

* Trigger Build

* Trigger Build

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Co-authored-by: Geeta Chauhan <4461127+chauhang@users.noreply.github.com>
Co-authored-by: Aaqib <maaquib@gmail.com>
Co-authored-by: Mark Saroufim <marksaroufim@fb.com>
jagadeeshi2i added a commit to jagadeeshi2i/serve that referenced this pull request Nov 3, 2022
* fix: volume permission in torchserve kubernetes

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>

* Trigger Build

* Trigger Build

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Co-authored-by: Geeta Chauhan <4461127+chauhang@users.noreply.github.com>
Co-authored-by: Aaqib <maaquib@gmail.com>
Co-authored-by: Mark Saroufim <marksaroufim@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing helm charts fails with missing securityContext.groupId
5 participants