-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pv creation for k8s setup #1751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
msaroufim
approved these changes
Jul 21, 2022
chauhang
reviewed
Jul 22, 2022
chauhang
reviewed
Jul 22, 2022
chauhang
reviewed
Jul 22, 2022
chauhang
reviewed
Jul 22, 2022
chauhang
suggested changes
Jul 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagadeeshi2i Thanks for the PR. Please see the comments inline
- change cluster and security group name - remove poliy-arn ref - add note on efs-provisioner deprecation Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Codecov Report
@@ Coverage Diff @@
## master #1751 +/- ##
==========================================
+ Coverage 41.67% 44.95% +3.28%
==========================================
Files 55 63 +8
Lines 2282 2609 +327
Branches 1 56 +55
==========================================
+ Hits 951 1173 +222
- Misses 1331 1436 +105
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chauhang
reviewed
Aug 29, 2022
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
chauhang
approved these changes
Sep 22, 2022
jagadeeshi2i
added a commit
to jagadeeshi2i/serve
that referenced
this pull request
Nov 1, 2022
* fix: pv creation for k8s setup Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com> * fix: readme doc - change cluster and security group name - remove poliy-arn ref - add note on efs-provisioner deprecation Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com> * fix: file system id in eks readme Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com> * Trigger Build Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com> Co-authored-by: Geeta Chauhan <4461127+chauhang@users.noreply.github.com> Co-authored-by: Mark Saroufim <marksaroufim@fb.com>
jagadeeshi2i
added a commit
to jagadeeshi2i/serve
that referenced
this pull request
Nov 3, 2022
* fix: pv creation for k8s setup Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com> * fix: readme doc - change cluster and security group name - remove poliy-arn ref - add note on efs-provisioner deprecation Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com> * fix: file system id in eks readme Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com> * Trigger Build Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com> Co-authored-by: Geeta Chauhan <4461127+chauhang@users.noreply.github.com> Co-authored-by: Mark Saroufim <marksaroufim@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jagadeesh jagadeeshj@ideas2it.com
Description
Updated the PV creation steps for TS kubernetes with aws-efs-csi-driver as efs-provisioner is not maintained anymore.
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B
Checklist: