Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pv creation for k8s setup #1751

Merged
merged 11 commits into from
Oct 3, 2022
Merged

Conversation

jagadeeshi2i
Copy link
Collaborator

@jagadeeshi2i jagadeeshi2i commented Jul 21, 2022

Signed-off-by: jagadeesh jagadeeshj@ideas2it.com

Description

Updated the PV creation steps for TS kubernetes with aws-efs-csi-driver as efs-provisioner is not maintained anymore.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
@msaroufim msaroufim self-requested a review July 21, 2022 14:43
kubernetes/EKS/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chauhang chauhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jagadeeshi2i Thanks for the PR. Please see the comments inline

 - change cluster and security group name
 - remove poliy-arn ref
 - add note on efs-provisioner deprecation

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #1751 (802fd9b) into master (870fd8e) will increase coverage by 3.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1751      +/-   ##
==========================================
+ Coverage   41.67%   44.95%   +3.28%     
==========================================
  Files          55       63       +8     
  Lines        2282     2609     +327     
  Branches        1       56      +55     
==========================================
+ Hits          951     1173     +222     
- Misses       1331     1436     +105     
Impacted Files Coverage Δ
...w-archiver/workflow_archiver/workflow_packaging.py 89.65% <0.00%> (ø)
...l-archiver/model_archiver/model_packaging_utils.py 54.96% <0.00%> (ø)
workflow-archiver/workflow_archiver/version.py 100.00% <0.00%> (ø)
...el-archiver/model_archiver/model_archiver_error.py 100.00% <0.00%> (ø)
...iver/workflow_archiver/workflow_packaging_utils.py 68.68% <0.00%> (ø)
model-archiver/model_archiver/model_packaging.py 90.00% <0.00%> (ø)
...hiver/workflow_archiver/workflow_archiver_error.py 100.00% <0.00%> (ø)
model-archiver/model_archiver/version.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

kubernetes/EKS/README.md Outdated Show resolved Hide resolved
@msaroufim msaroufim added triaged Issue has been reviewed and triaged kubernetes labels Sep 26, 2022
@msaroufim msaroufim merged commit 6b4dc84 into pytorch:master Oct 3, 2022
jagadeeshi2i added a commit to jagadeeshi2i/serve that referenced this pull request Nov 1, 2022
* fix: pv creation for k8s setup

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>

* fix: readme doc

 - change cluster and security group name
 - remove poliy-arn ref
 - add note on efs-provisioner deprecation

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>

* fix: file system id in eks readme

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>

* Trigger Build

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Co-authored-by: Geeta Chauhan <4461127+chauhang@users.noreply.github.com>
Co-authored-by: Mark Saroufim <marksaroufim@fb.com>
jagadeeshi2i added a commit to jagadeeshi2i/serve that referenced this pull request Nov 3, 2022
* fix: pv creation for k8s setup

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>

* fix: readme doc

 - change cluster and security group name
 - remove poliy-arn ref
 - add note on efs-provisioner deprecation

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>

* fix: file system id in eks readme

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>

* Trigger Build

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Co-authored-by: Geeta Chauhan <4461127+chauhang@users.noreply.github.com>
Co-authored-by: Mark Saroufim <marksaroufim@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kubernetes triaged Issue has been reviewed and triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants