-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Doc Automation dependencies #1759
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1759 +/- ##
=========================================
Coverage ? 45.38%
=========================================
Files ? 64
Lines ? 2591
Branches ? 60
=========================================
Hits ? 1176
Misses ? 1415
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but some thoughts in the comments.
After looking into #1744 I noticed we don't actually use our
docs/sphinx/requirements.txt
in CI, this is not great because if there's issues with upstream dependencies likemarkdown
it means we need to fix them in 2 places.We also have a
.bat
file checked in even though we don't really need to be building our docs on Windows.Important part is this
To repro