Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade hpa with v2beta2 api version #1760

Merged
merged 6 commits into from
Oct 3, 2022

Conversation

jagadeeshi2i
Copy link
Collaborator

@jagadeeshi2i jagadeeshi2i commented Jul 24, 2022

Signed-off-by: jagadeesh jagadeeshj@ideas2it.com

Description

Kubernetes hpa object API version upgrade from v2beta1 to v2beta2. V1beta1 will be deprecated from 1.22+ Kubernetes version.

Gif of pod autoscaling
hpa

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #1760 (8f67bf9) into master (23a7671) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1760   +/-   ##
=======================================
  Coverage   44.95%   44.95%           
=======================================
  Files          63       63           
  Lines        2609     2609           
  Branches       56       56           
=======================================
  Hits         1173     1173           
  Misses       1436     1436           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim merged commit bb5ac4b into pytorch:master Oct 3, 2022
jagadeeshi2i added a commit to jagadeeshi2i/serve that referenced this pull request Nov 1, 2022
* fix: upgrade hpa with v2beta2 api version

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>

* Trigger Build

* Trigger Build

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Co-authored-by: Mark Saroufim <marksaroufim@fb.com>
jagadeeshi2i added a commit to jagadeeshi2i/serve that referenced this pull request Nov 3, 2022
* fix: upgrade hpa with v2beta2 api version

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>

* Trigger Build

* Trigger Build

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Co-authored-by: Mark Saroufim <marksaroufim@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants