Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade PT to 1.12 #1767

Merged
merged 15 commits into from
Aug 15, 2022
Merged

upgrade PT to 1.12 #1767

merged 15 commits into from
Aug 15, 2022

Conversation

lxning
Copy link
Collaborator

@lxning lxning commented Jul 26, 2022

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)
#1762

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@lxning lxning self-assigned this Jul 26, 2022
@lxning lxning added the enhancement New feature or request label Jul 26, 2022
@lxning lxning added this to the v0.6.1 milestone Jul 26, 2022
@lxning lxning added this to in process in v0.6.1 lifecycle Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #1767 (8b28d07) into master (e327e6e) will not change coverage.
The diff coverage is n/a.

❗ Current head 8b28d07 differs from pull request most recent head 4c3fae3. Consider uploading reports for the commit 4c3fae3 to get more accurate results

@@           Coverage Diff           @@
##           master    #1767   +/-   ##
=======================================
  Coverage   45.38%   45.38%           
=======================================
  Files          64       64           
  Lines        2591     2591           
  Branches       60       60           
=======================================
  Hits         1176     1176           
  Misses       1415     1415           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lxning lxning added the p0 high priority label Jul 28, 2022
@lxning lxning requested review from mreso and maaquib July 28, 2022 00:58
@lxning lxning changed the title [wip]upgrade PT to 1.12 upgrade PT to 1.12 Jul 28, 2022
Copy link
Contributor

@chauhang chauhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments inline. Further check what changes are needed for torch_cu102_windows.txt

@mreso mreso requested a review from chauhang July 28, 2022 03:06
@lxning
Copy link
Collaborator Author

lxning commented Jul 28, 2022

Please see comments inline. Further check what changes are needed for torch_cu102_windows.txt

PT1.12 does not support cu102 on windows

Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chauhang
Copy link
Contributor

chauhang commented Aug 4, 2022

@lxning Please check the Codebuild errors, failing for all the cases

@lxning lxning merged commit 7a9dd02 into master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p0 high priority
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants