-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade PT to 1.12 #1767
upgrade PT to 1.12 #1767
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1767 +/- ##
=======================================
Coverage 45.38% 45.38%
=======================================
Files 64 64
Lines 2591 2591
Branches 60 60
=======================================
Hits 1176 1176
Misses 1415 1415 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…l_archiver fixture and fixed issue caused by pytorch/text#1849
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments inline. Further check what changes are needed for torch_cu102_windows.txt
PT1.12 does not support cu102 on windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lxning Please check the Codebuild errors, failing for all the cases |
Description
Please read our CONTRIBUTING.md prior to creating your first pull request.
Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
#1762
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Checklist: