fix: model status API for kserve #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Codecov Report
@@ Coverage Diff @@
## master #1773 +/- ##
=======================================
Coverage 45.19% 45.19%
=======================================
Files 64 64
Lines 2604 2604
Branches 60 60
=======================================
Hits 1177 1177
Misses 1427 1427 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chauhang
reviewed
Jul 28, 2022
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
jagadeeshi2i
changed the title
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
|
@jagadeeshi2i Windows CI is known to flake so CI is all green |
chauhang
approved these changes
Aug 29, 2022
agunapal
requested changes
Sep 19, 2022
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
…hi1i/serve into fix/model-status-kserve
4 tasks
jagadeeshi2i
added a commit
to jagadeeshi2i/serve
that referenced
this pull request
Nov 1, 2022
* fix: model status API for kserve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jagadeesh jagadeeshj@ideas2it.com
Description
fixes: kserve/kserve-1915
Issue: kserve model status API returns ready status only after a predict request as model is not loaded in startup.
Soln: Loads all TS models at start with
load_modelsproperty and kserve load model method.Gif of model status working after TS isvc deployment.
model-status.log
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B
Checklist: