Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate neuron Dockerfile in favor in DLC #1775

Merged
merged 10 commits into from
Aug 16, 2022

Conversation

rohithkrn
Copy link
Collaborator

This change is to deprecate neuron dockerfile as it is currently broken. Instead, it's ideal at this to point use containers provided by aws/deep-learning-containers that are more reliable.

I also learnt that this was created to run performance tests but it was never run/tested.

Packages that are missing in this Dockerfile

  • python3.8, python3.8-dev, python3.8-venv, python3.8-distutils. It installs python3-dev
  • gnupg

I tried installing these packages and ran the container but it did not detect neuron devices inside the container probably because of missing drivers.

Ran the docker container like below following https://awsdocs-neuron.readthedocs-hosted.com/en/latest/neuron-deploy/dlc-then-ec2-devflow.html#
docker run -it --name ts-jdk17 --rm --shm-size=1g -p 8080:8080 -p 8081:8081 -p 8082:8082 -e "AWS_NEURON_VISIBLE_DEVICES=ALL" -v $HOME/torchserve:/workspace ts-neuron-jdk17
Inside the container neuron-ls does not return anything.

@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #1775 (a5b655d) into master (f20388b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1775   +/-   ##
=======================================
  Coverage   45.28%   45.28%           
=======================================
  Files          64       64           
  Lines        2597     2597           
  Branches       60       60           
=======================================
  Hits         1176     1176           
  Misses       1421     1421           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rohithkrn rohithkrn requested a review from lxning August 2, 2022 15:55
@lxning
Copy link
Collaborator

lxning commented Aug 2, 2022

@rohithkrn please highlight deprecation message in README.md

@rohithkrn
Copy link
Collaborator Author

@rohithkrn please highlight deprecation message in README.md

@lxning Updated. Thanks

@rohithkrn rohithkrn requested a review from maaquib August 2, 2022 20:43
@msaroufim msaroufim self-requested a review August 16, 2022 00:26
@msaroufim msaroufim merged commit aa2468d into pytorch:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants