Gracefully handle decoding exceptions in python backend #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaroufim
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1789 +/- ##
==========================================
- Coverage 45.38% 45.28% -0.11%
==========================================
Files 64 64
Lines 2591 2597 +6
Branches 60 60
==========================================
Hits 1176 1176
- Misses 1415 1421 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
agunapal
reviewed
Aug 11, 2022
|
@rohithkrn @lxning GPU CI seems to be frozen now |
maaquib
reviewed
Aug 11, 2022
maaquib
reviewed
Aug 12, 2022
Co-authored-by: Aaqib <maaquib@gmail.com>
Co-authored-by: Aaqib <maaquib@gmail.com>
maaquib
approved these changes
Aug 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1776
Test: https://colab.research.google.com/drive/1eKMiheF50YYGtPmi0WqVkeRqLk8Gbwg5?usp=sharing (would probably be better to start writing unit tests for the python backend when we have time)
The meaningful code is at the very end of the file in the
try, exceptblock