Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates examples/intel_extension_for_pytorch README #1816

Merged
merged 4 commits into from
Aug 26, 2022

Conversation

min-jean-cho
Copy link
Collaborator

This PR updates examples/intel_extension_for_pytorch README -- fixes few typos, wordings, and updates IPEX int8 API

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #1816 (2acfd90) into master (a916ee5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1816   +/-   ##
=======================================
  Coverage   45.28%   45.28%           
=======================================
  Files          64       64           
  Lines        2597     2597           
  Branches       60       60           
=======================================
  Hits         1176     1176           
  Misses       1421     1421           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@min-jean-cho
Copy link
Collaborator Author

Hi @msaroufim, please help review this PR. Thanks!

@agunapal
Copy link
Collaborator

@min-jean-cho I have a general comment/question about the changes.
Why don't we say intel-extension-for-pytorch (IPEX) and then use IPEX everywhere else?
The code is still using ipex for short. So, that would keep the format consistent

@min-jean-cho
Copy link
Collaborator Author

@min-jean-cho I have a general comment/question about the changes. Why don't we say intel-extension-for-pytorch (IPEX) and then use IPEX everywhere else? The code is still using ipex for short. So, that would keep the format consistent

Thanks @agunapal, we don't want to use IPEX in formal docs. cc @jingxu10

@jingxu10
Copy link

Hi @agunapal, as we got instructed from Intel Legal, Intel® Extension for PyTorch* is a TM&B. We must use this exactly the same text when mentioning it in docs or reading materials.

@agunapal
Copy link
Collaborator

Thanks @min-jean-cho and @jingxu10 for the context

@agunapal agunapal merged commit b8c23e6 into pytorch:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants