Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pynvml import failure #1882

Merged
merged 2 commits into from
Sep 29, 2022
Merged

fix pynvml import failure #1882

merged 2 commits into from
Sep 29, 2022

Conversation

lxning
Copy link
Collaborator

@lxning lxning commented Sep 29, 2022

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)
#1881

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

Only "import pynvml" in gpu host.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@lxning lxning self-assigned this Sep 29, 2022
@lxning lxning added the bug Something isn't working label Sep 29, 2022
@lxning lxning added this to the v0.6.1 milestone Sep 29, 2022
@lxning lxning added benchmark p0 high priority labels Sep 29, 2022
@rohithkrn
Copy link
Collaborator

@lxning curious why this was not an issue always and only showed up recently?

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Shouldn't the CPU benchmark CI always be failing because of this?

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1882 (8df0285) into master (b30c341) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 8df0285 differs from pull request most recent head 01e41ab. Consider uploading reports for the commit 01e41ab to get more accurate results

@@            Coverage Diff             @@
##           master    #1882      +/-   ##
==========================================
- Coverage   44.99%   44.95%   -0.04%     
==========================================
  Files          63       63              
  Lines        2609     2609              
  Branches       60       60              
==========================================
- Hits         1174     1173       -1     
- Misses       1435     1436       +1     
Impacted Files Coverage Δ
ts/metrics/system_metrics.py 28.81% <0.00%> (-1.70%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lxning
Copy link
Collaborator Author

lxning commented Sep 29, 2022

@lxning curious why this was not an issue always and only showed up recently?

@rohithkrn This issue happened recently due to PR. It causes CPU usage report different from previous.

@lxning
Copy link
Collaborator Author

lxning commented Sep 29, 2022

Looks good. Shouldn't the CPU benchmark CI always be failing because of this?

@ankithagunapal I found PR caused cpu usage abnormal, but not sure if it is also related to recent CPU benchmark unstable.

@rohithkrn rohithkrn requested review from rohithkrn and removed request for rohan-varma September 29, 2022 17:25
@msaroufim msaroufim merged commit 723e8fd into master Sep 29, 2022
jagadeeshi2i pushed a commit to jagadeeshi2i/serve that referenced this pull request Nov 1, 2022
jagadeeshi2i pushed a commit to jagadeeshi2i/serve that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark bug Something isn't working p0 high priority
Projects
v0.6.1 lifecycle
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants