Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip spellcheck if no changed files #1919

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Conversation

maaquib
Copy link
Collaborator

@maaquib maaquib commented Oct 20, 2022

Description

Skips spellcheck in CI if no changed files found

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #1918

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

./ts_scripts/spellcheck.sh " "
++ sudo apt-get install aspell
Reading package lists... Done
Building dependency tree
Reading state information... Done
aspell is already the newest version (0.60.7~20110707-4ubuntu0.2).
The following packages were automatically installed and are no longer required:
  linux-aws-5.4-headers-5.4.0-1075 linux-aws-5.4-headers-5.4.0-1078 linux-aws-5.4-headers-5.4.0-1080 linux-aws-5.4-headers-5.4.0-1081 linux-aws-5.4-headers-5.4.0-1084 linux-aws-5.4-headers-5.4.0-1085 linux-headers-5.4.0-1085-aws
  linux-image-5.4.0-1085-aws linux-modules-5.4.0-1085-aws
Use 'sudo apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 49 not upgraded.
++ [[ -z   ]]
++ sources=' '
++ sources_arg=
++ '[' '!' '' ']'
++ echo 'No files to spellcheck'
No files to spellcheck



./ts_scripts/spellcheck.sh CONTRIBUTING.md README.md
++ sudo apt-get install aspell
Reading package lists... Done
Building dependency tree
Reading state information... Done
aspell is already the newest version (0.60.7~20110707-4ubuntu0.2).
The following packages were automatically installed and are no longer required:
  linux-aws-5.4-headers-5.4.0-1075 linux-aws-5.4-headers-5.4.0-1078 linux-aws-5.4-headers-5.4.0-1080 linux-aws-5.4-headers-5.4.0-1081 linux-aws-5.4-headers-5.4.0-1084 linux-aws-5.4-headers-5.4.0-1085 linux-headers-5.4.0-1085-aws
  linux-image-5.4.0-1085-aws linux-modules-5.4.0-1085-aws
Use 'sudo apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 49 not upgraded.
++ [[ -z CONTRIBUTING.md README.md ]]
++ sources='CONTRIBUTING.md README.md'
++ sources_arg=
++ for src in $sources
++ sources_arg=' -S CONTRIBUTING.md'
++ for src in $sources
++ sources_arg=' -S CONTRIBUTING.md -S README.md'
++ '[' '!' ' -S CONTRIBUTING.md -S README.md' ']'
++ pyspelling -c ts_scripts/spellcheck_conf/spellcheck.yaml --name Markdown -S CONTRIBUTING.md -S README.md
Spelling check passed :)

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #1919 (881dcaf) into master (877c7b6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1919   +/-   ##
=======================================
  Coverage   44.95%   44.95%           
=======================================
  Files          63       63           
  Lines        2609     2609           
  Branches       56       56           
=======================================
  Hits         1173     1173           
  Misses       1436     1436           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maaquib maaquib marked this pull request as ready for review October 20, 2022 19:46
@maaquib maaquib merged commit 82baad9 into pytorch:master Oct 21, 2022
jagadeeshi2i pushed a commit to jagadeeshi2i/serve that referenced this pull request Nov 1, 2022
jagadeeshi2i pushed a commit to jagadeeshi2i/serve that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spellcheck fails if no changed src files
3 participants