Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds DeepSpeed MII example #1920

Merged
merged 15 commits into from
Nov 8, 2022

Conversation

jagadeeshi2i
Copy link
Collaborator

@jagadeeshi2i jagadeeshi2i commented Oct 20, 2022

Signed-off-by: jagadeesh jagadeeshj@ideas2it.com

Description

  • Adds example of stable diffusion model using DeepSpeed MII

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #1920 (c083a20) into master (0942611) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1920   +/-   ##
=======================================
  Coverage   44.95%   44.95%           
=======================================
  Files          63       63           
  Lines        2609     2609           
  Branches       56       56           
=======================================
  Hits         1173     1173           
  Misses       1436     1436           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

 - add requirements file
 - add config.properties
 - fix handler inference params
 - add model param to setup_config

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
@jagadeeshi2i jagadeeshi2i changed the title [WIP] feat: Adds DeepSpeed MII example feat: Adds DeepSpeed MII example Oct 26, 2022
examples/deepspeed_mii/Readme.md Outdated Show resolved Hide resolved
 - fix readme doc

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
…eepspee_mii

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Copy link
Collaborator

@lxning lxning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you provide the test log for the example?

examples/deepspeed_mii/config.properties Outdated Show resolved Hide resolved
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

 - remove snapshot from config.properties

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Copy link
Collaborator

@HamidShojanazeri HamidShojanazeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for code freeze.

@msaroufim msaroufim merged commit a5fc61f into pytorch:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants